Skip to content

feat: add input artifact when creating a pipeline#1593

Merged
jaycee-li merged 26 commits into
googleapis:mainfrom
rui5i:input_artifact
Sep 6, 2022
Merged

feat: add input artifact when creating a pipeline#1593
jaycee-li merged 26 commits into
googleapis:mainfrom
rui5i:input_artifact

Conversation

@rui5i
Copy link
Copy Markdown
Contributor

@rui5i rui5i commented Aug 12, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1592 🦕

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Aug 12, 2022
@sararob sararob self-requested a review August 12, 2022 20:14
Copy link
Copy Markdown
Contributor

@sararob sararob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this! Do you have an example pipeline that takes an input artifact uri as a parameter? I think that would help me understand how this feature will be used in the SDK.

Comment thread google/cloud/aiplatform/pipeline_jobs.py Outdated
@rui5i rui5i changed the title Add input artifact when creating a pipeline feet: add input artifact when creating a pipeline Aug 17, 2022
@rui5i rui5i changed the title feet: add input artifact when creating a pipeline feat: add input artifact when creating a pipeline Aug 17, 2022
@rui5i rui5i requested a review from a team August 17, 2022 18:28
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 17, 2022
Comment thread tests/unit/aiplatform/test_pipeline_jobs.py
Comment thread tests/unit/aiplatform/test_pipeline_jobs.py Outdated
Comment thread google/cloud/aiplatform/pipeline_jobs.py
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Aug 25, 2022
@rui5i
Copy link
Copy Markdown
Contributor Author

rui5i commented Aug 25, 2022

/test

Comment thread tests/unit/aiplatform/test_pipeline_jobs.py Outdated
Comment thread google/cloud/aiplatform/pipeline_jobs.py
@rui5i rui5i requested a review from SinaChavoshi August 30, 2022 22:59
Copy link
Copy Markdown
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! lgtm.

Comment thread google/cloud/aiplatform/pipeline_jobs.py
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@jaycee-li jaycee-li added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@jaycee-li jaycee-li merged commit 2cf9fe6 into googleapis:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support input artifacts when creating pipeline job

6 participants