fix: Pass the PipelineJob credentials to create_gcs_bucket_for_pipeline_artifacts_if_it_does_not_exist#1537
Merged
Conversation
…ine_artifacts_if_it_does_not_exist`
product-auto-label
Bot
added
size: xs
sararob
requested changes
Jul 22, 2022
Contributor
sararob
left a comment
sararob
left a comment
There was a problem hiding this comment.
Thanks for this! Could you also add a unit test for cases when aiplatform.init is not called before calling PipelineJob.submit()?
Contributor
Author
What is the behavior that such test would needs to check? Note that unit tests are executed without accessing any real infrastructure (GCS or PipelineService). |
sararob
approved these changes
Jul 22, 2022
…ate_gcs_bucket_for_pipeline_artifacts_if_it_does_not_exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕