Skip to content

feat: Add samples for Metadata context list, get, and create#1525

Merged
SinaChavoshi merged 18 commits into
googleapis:mainfrom
SinaChavoshi:sdk_samples_list_get_create_for_context
Jul 25, 2022
Merged

feat: Add samples for Metadata context list, get, and create#1525
SinaChavoshi merged 18 commits into
googleapis:mainfrom
SinaChavoshi:sdk_samples_list_get_create_for_context

Conversation

@SinaChavoshi
Copy link
Copy Markdown
Contributor

Note that this cl will fail until the dependancies are checked in.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@SinaChavoshi SinaChavoshi requested a review from a team July 20, 2022 07:05
@SinaChavoshi SinaChavoshi requested a review from a team as a code owner July 20, 2022 07:05
@SinaChavoshi SinaChavoshi requested a review from dandhlee July 20, 2022 07:05
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Jul 20, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jul 20, 2022

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. labels Jul 20, 2022
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jul 20, 2022
Copy link
Copy Markdown
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments.

Comment thread samples/model-builder/experiment_tracking/get_context_sample.py
Comment thread samples/model-builder/experiment_tracking/list_context_sample.py
Comment thread samples/model-builder/experiment_tracking/list_context_sample_test.py Outdated
Comment thread samples/model-builder/experiment_tracking/get_context_sample_test.py Outdated
Comment thread samples/model-builder/experiment_tracking/get_context_sample_test.py Outdated
Comment thread samples/model-builder/experiment_tracking/list_context_sample_test.py Outdated
Comment thread samples/model-builder/experiment_tracking/list_context_sample_test.py Outdated
Comment thread samples/model-builder/experiment_tracking/list_context_sample_test.py Outdated
SinaChavoshi and others added 5 commits July 25, 2022 10:29
…est.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
…test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
…test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
…est.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
@product-auto-label product-auto-label Bot removed the size: m Pull request size is medium. label Jul 25, 2022
@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Jul 25, 2022
Copy link
Copy Markdown
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SinaChavoshi SinaChavoshi merged commit d913e1d into googleapis:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants