fix(core): Handle nil response in on_data callback for Faraday streaming#24235
Merged
aandreassa merged 2 commits intomainfrom Sep 9, 2025
Merged
fix(core): Handle nil response in on_data callback for Faraday streaming#24235aandreassa merged 2 commits intomainfrom
aandreassa merged 2 commits intomainfrom
Conversation
viacheslav-rostovtsev
previously approved these changes
Sep 8, 2025
viacheslav-rostovtsev
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to cdf6281#diff-81af43dded9cb6b9079107b8c2003553e23df305cfbae8c59ba69407feb09890
Fixes
NoMethodErrorduring streaming downloads when using Faraday 2.x with an adapter like typhoeus.Issue: https://github.com/googleapis/google-cloud-ruby/issues/30902
Tested locally using
google-cloud-storage