Ensure compatibility with ruby --enable-frozen-string-literal#21648
Merged
dazuma merged 1 commit intogoogleapis:mainfrom Apr 30, 2025
Merged
Ensure compatibility with ruby --enable-frozen-string-literal#21648dazuma merged 1 commit intogoogleapis:mainfrom
dazuma merged 1 commit intogoogleapis:mainfrom
Conversation
byroot
force-pushed
the
fix-frozen-string-warnings
branch
3 times, most recently
from
7e5646b to
b26aa46
Compare
|
It would be great if this could be released soon. These warnings massively pile up in my logs under ruby 3.4. |
Ref: https://bugs.ruby-lang.org/issues/20205 Since Ruby 2.4 it is possible to run ruby with `--enable-frozen-string-literal` and it's supposed to be the default behavior in the future. It just require some very minor change for this gem to be compatible.
byroot
force-pushed
the
fix-frozen-string-warnings
branch
from
b26aa46 to
9773609
Compare
Contributor
Author
|
@dazuma sorry for the ping, but would you have time to look at this PR? This will become a compatibility issue in the near future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/20205
Since Ruby 2.4 it is possible to run ruby with
--enable-frozen-string-literaland it's supposed to be the default behavior in the future.It just require some very minor change for this gem to be compatible.