Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

feat: add snippetgen config language and golden files#1504

Merged
dizcology merged 12 commits into
googleapis:mainfrom
dizcology:snippet-config-0
Dec 5, 2022
Merged

feat: add snippetgen config language and golden files#1504
dizcology merged 12 commits into
googleapis:mainfrom
dizcology:snippet-config-0

Conversation

@dizcology
Copy link
Copy Markdown
Contributor

@dizcology dizcology commented Nov 30, 2022

Prototype code for configurable snippet generation code. This PR includes the snippet configuration language definition and golden test files only.

@dizcology dizcology requested review from a team November 30, 2022 23:34
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Nov 30, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Nov 30, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dizcology dizcology requested a review from parthea November 30, 2022 23:34
@dizcology dizcology added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2022
@dizcology dizcology added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 4, 2022
@dizcology dizcology removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 4, 2022
@dizcology dizcology added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
parthea
parthea approved these changes Dec 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please can you update the docs or include a README with more information about how these files were created?

Comment thread tests/configurable_snippetgen/test_resources.py Outdated
# This is a copy of the CodeGeneratorRequest dumped with:
# protoc google/cloud/speech/v1/*.proto \
# --experimental_allow_proto3_optional \
# --proto_path=../api-common-protos/ --proto_path=. \
Copy link
Copy Markdown
Contributor

@parthea parthea Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api-common-protos is deprecated. Is it possible to use googleapis/googleapis instead?

Copy link
Copy Markdown
Contributor Author

@dizcology dizcology Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added resources/README.md for how to regenerate the file. Also replaced request.desc with one dumped without using api-common-protos.

Copy link
Copy Markdown
Contributor

@parthea parthea Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the comment here also which mentions api-common-protos

Copy link
Copy Markdown
Contributor Author

@dizcology dizcology Dec 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (removed the whole comment block, since the updated info is already in README.md) - thanks!

@dizcology dizcology added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@dizcology dizcology added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@dizcology dizcology added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@dizcology dizcology merged commit 5b98659 into googleapis:main Dec 5, 2022
@release-please release-please Bot mentioned this pull request Dec 5, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dizcology @parthea