This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: Resolve some Showcase test errors#1353
Merged
Merged
Conversation
vchudnov-g
force-pushed
the
work-with-showcase
branch
from
c571601 to
dd95cb0
Compare
vchudnov-g
force-pushed
the
work-with-showcase
branch
from
dd95cb0 to
f89d559
Compare
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
This changes the code to expect the correct exceptions
vchudnov-g
force-pushed
the
work-with-showcase
branch
from
f89d559 to
98311ef
Compare
vchudnov-g
added
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
vchudnov-g
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
vchudnov-g
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
parthea
approved these changes
Sep 2, 2023
Contributor
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
LGTM, added one observation regarding the code comment
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the code to expect the correct exceptions