Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: sanitize file names#1236

Merged
parthea merged 5 commits into
mainfrom
sanitize-file-names
Mar 23, 2022
Merged

fix: sanitize file names#1236
parthea merged 5 commits into
mainfrom
sanitize-file-names

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Mar 16, 2022

Fixes: #1238

@parthea parthea marked this pull request as ready for review March 17, 2022 09:47
@parthea parthea requested review from a team March 17, 2022 09:47
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atulep Could you also take a look?

@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Mar 22, 2022

Hi @atulep, please could you review/approve?

Copy link
Copy Markdown
Contributor

@atulep atulep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments yesterday, but I didn't realize my review was "pending". Sorry for delay.

Comment thread tests/unit/schema/test_api.py
@parthea parthea requested a review from atulep March 22, 2022 23:38
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Mar 23, 2022

All review comments have been addressed. Merging.

@parthea parthea merged commit 3072ffb into main Mar 23, 2022
@parthea parthea deleted the sanitize-file-names branch March 23, 2022 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sanitize file names

3 participants