Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

fix: add javadoc for ApiFutures#1609

Merged
JoeWang1127 merged 6 commits into
mainfrom
fix/ApiFutures-doc
Apr 6, 2023
Merged

fix: add javadoc for ApiFutures#1609
JoeWang1127 merged 6 commits into
mainfrom
fix/ApiFutures-doc

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

Fixes #1239 ☕️

@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Apr 5, 2023
@JoeWang1127 JoeWang1127 marked this pull request as ready for review April 5, 2023 20:02
@JoeWang1127 JoeWang1127 requested review from a team, blakeli0 and burkedavison April 5, 2023 20:02
Comment thread api-common-java/src/main/java/com/google/api/core/ApiFutures.java Outdated
Comment thread api-common-java/src/main/java/com/google/api/core/ApiFutures.java Outdated
Comment thread api-common-java/src/main/java/com/google/api/core/ApiFutures.java
@JoeWang1127 JoeWang1127 requested a review from burkedavison April 5, 2023 22:12
Comment thread api-common-java/src/main/java/com/google/api/core/ApiFutures.java Outdated
Comment thread api-common-java/src/main/java/com/google/api/core/ApiFutures.java Outdated
@JoeWang1127 JoeWang1127 requested a review from blakeli0 April 6, 2023 17:46
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@burkedavison
Copy link
Copy Markdown
Member

LGTM

@JoeWang1127 JoeWang1127 merged commit 4bb0a5e into main Apr 6, 2023
@JoeWang1127 JoeWang1127 deleted the fix/ApiFutures-doc branch April 6, 2023 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Javadoc over methods in ApiFutures

3 participants