refactor(git/repo/base): use less strict types in is_ancestor#2132
Closed
comeillfoo wants to merge 1 commit intogitpython-developers:mainfrom
Closed
refactor(git/repo/base): use less strict types in is_ancestor#2132comeillfoo wants to merge 1 commit intogitpython-developers:mainfrom
comeillfoo wants to merge 1 commit intogitpython-developers:mainfrom
Conversation
Changes the type hints in the is_ancestor arguments to avoid warnings from type checkers (e.g. Pylance).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Repo.is_ancestor() type hints in git/repo/base.py to be less strict, aiming to reduce warnings from static type checkers (e.g., Pylance) when callers pass revision-like objects that aren’t strictly Commit.
Changes:
- Relaxed the
ancestor_revandrevparameter annotations forRepo.is_ancestor()(fromCommittoTBD).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return res | ||
|
|
||
| def is_ancestor(self, ancestor_rev: Commit, rev: Commit) -> bool: | ||
| def is_ancestor(self, ancestor_rev: TBD, rev: TBD) -> bool: |
Member
|
Thanks, but is there a way to type this properly? The warnings this causes are also unspecific enough to make this more of a local fix than anything that should be merged. Closing, but feel free to reopen if a more thorough fix is possible and desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the type hints in the is_ancestor arguments to avoid warnings from type checkers (e.g. Pylance).