fix: let get_me handle missing arguments#2591
Conversation
24cf9ff to
86ba852
Compare
|
Updated this branch onto current Validated locally: |
86ba852 to
0ba6ee1
Compare
|
Rebased this branch on the latest upstream Validated: All passed. |
|
Re-ran validation on the current branch:\n\n- \go test ./pkg/github -run Test_GetMe -count=1\n- \go test ./pkg/github -count=1\n- \go test ./...\n- \git diff --check origin/main...HEAD\n\nAll passed locally on Windows. |
0ba6ee1 to
65fca9b
Compare
|
Rebased this branch onto the latest upstream Validated locally:
|
65fca9b to
b52eecc
Compare
|
Rebased this branch onto current upstream Validation on Windows: All passed. |
b52eecc to
5c68c75
Compare
|
Rebased the approved branch onto current upstream Validation on Windows:
|
Fixes #2587.
Summary
get_meis a zero-argument tool, but it was registered through the generic argument-decoding helper. That still makes the call sensitive to whether a client sends{}or omitsargumentsentirely.This patch registers
get_mewith the no-argument handler path instead. The handler does not need parsed arguments, so it can serve both forms consistently:arguments: {}argumentsfieldValidation
go test ./pkg/github -run Test_GetMe -count=1go test ./pkg/github -count=1go test ./... -count=1gofmt -w pkg/github/context_tools.go pkg/github/context_tools_test.gogit diff --check origin/main..HEAD