Skip to content

Add timeout for registry image publish#1173

Closed
MattBabbage wants to merge 33 commits into
mainfrom
matt/registry-pipeline-version-change
Closed

Add timeout for registry image publish#1173
MattBabbage wants to merge 33 commits into
mainfrom
matt/registry-pipeline-version-change

Conversation

@MattBabbage

Copy link
Copy Markdown
Contributor

This pull request updates the MCP server release workflow, Docker image, and configuration to improve reliability, ensure compliance with MCP registry requirements, and fix metadata issues.

@MattBabbage MattBabbage requested a review from a team as a code owner October 3, 2025 10:23
Copilot AI review requested due to automatic review settings October 3, 2025 10:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the MCP server release workflow by adding timeout mechanisms for Docker image publishing, updating schema versions for compliance, and improving configuration validation. The changes focus on reliability improvements for the registry publishing process.

Key changes:

  • Added timeout logic to wait for Docker image availability before registry publishing
  • Updated MCP schema version and cleaned up server configuration
  • Enhanced workflow with better error handling and validation steps

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
server.json Updated schema version and cleaned registry configuration
Dockerfile Added required MCP server annotation label
.github/workflows/registry-releaser.yml Enhanced workflow with timeout, validation, and better error handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/registry-releaser.yml
Comment thread .github/workflows/registry-releaser.yml Outdated
MattBabbage and others added 2 commits October 3, 2025 11:25
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SamMorrowDrums

Copy link
Copy Markdown
Collaborator

@MattBabbage is this something that still needs addressing?

@SamMorrowDrums

Copy link
Copy Markdown
Collaborator

Closing as superseded by #1174, which already landed the 'Wait for Docker image' step on main in a more complete form (10 retries / 5 min, plus the checkout@v6 bump). Thanks Matt — the only remaining unique change here was a cosmetic log-message tweak, not worth carrying a separate PR for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants