-
Notifications
You must be signed in to change notification settings - Fork 67.2k
More details for newbies #974
Copy link
Copy link
Closed
Labels
actionsThis issue or pull request should be reviewed by the docs actions teamThis issue or pull request should be reviewed by the docs actions teamgood first issueGood for newcomersGood for newcomershelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue
Metadata
Metadata
Assignees
Labels
actionsThis issue or pull request should be reviewed by the docs actions teamThis issue or pull request should be reviewed by the docs actions teamgood first issueGood for newcomersGood for newcomershelp wantedAnyone is welcome to open a pull request to fix this issueAnyone is welcome to open a pull request to fix this issue
Type
Fields
Give feedbackNo fields configured for issues without a type.
What article on docs.github.com is affected?
https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-docker-container-action
What part(s) of the article would you like to see updated?
As a total newbie to actions and Docker, I made a couple of silly mistakes when trying out the example.
First, in the
entrypoint.shfile, I wrote-1instead of-l.Second, the docker couldn't run the .sh file because of permissions, so I had to add
RUN chmod +x /entrypoint.shto the dockerfile.Also line
uses: actions/hello-world-docker-action@v1shows how to use published action. You should add that unpublished action is used viauses: [username]/[reponame]@version.So I think these 3 things should be pointed out there.