Change from using deprecated Branch.Remote to Branch.RemoteName

Author: jcansdale

src/GitHub.App/Services/PullRequestService.cs

@@ -106,9 +106,7 @@ public IObservable<Unit> Push(ILocalRepositoryModel repository)
             return Observable.Defer(async () =>
             {
                 var repo = gitService.GetRepository(repository.LocalPath);
-#pragma warning disable 0618 // Branch.Remote is deprecated
-                var remoteName = repo.Head.Remote.Name;
-#pragma warning restore 0618
+                var remoteName = repo.Head.RemoteName;
                 var remote = await gitClient.GetHttpRemote(repo, remoteName);
                 return gitClient.Push(repo, repo.Head.TrackedBranch.UpstreamBranchCanonicalName, remote.Name).ToObservable();
             });
@@ -369,12 +367,10 @@ public IObservable<Unit> RemoveUnusedRemotes(ILocalRepositoryModel repository)
             return Observable.Defer(async () =>
             {
                 var repo = gitService.GetRepository(repository.LocalPath);
-#pragma warning disable 0618 // Branch.Remote is deprecated
                 var usedRemotes = new HashSet<string>(
                     repo.Branches
-                        .Where(x => !x.IsRemote && x.Remote != null)
-                        .Select(x => x.Remote?.Name));
-#pragma warning restore 0618
+                        .Where(x => !x.IsRemote && x.RemoteName != null)
+                        .Select(x => x.RemoteName));
 
                 foreach (var remote in repo.Network.Remotes)
                 {

src/UnitTests/GitHub.App/Services/PullRequestServiceTests.cs

@@ -524,8 +524,8 @@ public async Task ShouldRemoveUnusedRemote()
             var branch2 = Substitute.For<LibGit2Sharp.Branch>();
             var branches = new List<LibGit2Sharp.Branch> { branch1, branch2 };
             var branchCollection = Substitute.For<BranchCollection>();
-            branch1.Remote.Returns(remote1);
-            branch2.Remote.Returns(remote1);
+            branch1.RemoteName.Returns("remote1");
+            branch2.RemoteName.Returns("remote1");
             branchCollection.GetEnumerator().Returns(_ => branches.GetEnumerator());
             repo.Branches.Returns(branchCollection);