Skip to content

Commit 3c4b97c

Browse files
authored
ref(top-issues): ui cleanup (#104202)
Actually implements some of the changes from #104197
1 parent 855acb2 commit 3c4b97c

File tree

1 file changed

+5
-55
lines changed

1 file changed

+5
-55
lines changed

static/app/views/issueList/pages/dynamicGrouping.tsx

Lines changed: 5 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {Heading, Text} from '@sentry/scraps/text';
88
import {Button} from 'sentry/components/core/button';
99
import {Checkbox} from 'sentry/components/core/checkbox';
1010
import {Disclosure} from 'sentry/components/core/disclosure';
11-
import {NumberInput} from 'sentry/components/core/input/numberInput';
1211
import {Link} from 'sentry/components/core/link';
1312
import {TextArea} from 'sentry/components/core/textarea';
1413
import EventOrGroupTitle from 'sentry/components/eventOrGroupTitle';
@@ -274,6 +273,11 @@ function ClusterCard({
274273
{/* Zone 1: Title + Description (Primary Focus) */}
275274
<CardHeader>
276275
<ClusterTitle>{cluster.title}</ClusterTitle>
276+
<ClusterTags
277+
cluster={cluster}
278+
onTagClick={onTagClick}
279+
selectedTags={selectedTags}
280+
/>
277281
{cluster.description && (
278282
<Fragment>
279283
{showDescription ? (
@@ -285,11 +289,6 @@ function ClusterCard({
285289
)}
286290
</Fragment>
287291
)}
288-
<ClusterTags
289-
cluster={cluster}
290-
onTagClick={onTagClick}
291-
selectedTags={selectedTags}
292-
/>
293292
</CardHeader>
294293

295294
{/* Zone 2: Stats (Secondary Context) */}
@@ -308,16 +307,6 @@ function ClusterCard({
308307
{tn('event', 'events', clusterStats.totalEvents)}
309308
</Text>
310309
</EventsMetric>
311-
{cluster.fixability_score && (
312-
<FixabilityIndicator score={cluster.fixability_score}>
313-
<Text size="sm" bold>
314-
{Math.round(cluster.fixability_score * 100)}%
315-
</Text>
316-
<Text size="xs" variant="muted">
317-
{t('fixable')}
318-
</Text>
319-
</FixabilityIndicator>
320-
)}
321310
</PrimaryStats>
322311
<SecondaryStats>
323312
{!clusterStats.isPending && clusterStats.lastSeen && (
@@ -388,7 +377,6 @@ function DynamicGrouping() {
388377
const [filterByAssignedToMe, setFilterByAssignedToMe] = useState(true);
389378
const [selectedTeamIds, setSelectedTeamIds] = useState<Set<string>>(new Set());
390379
const [selectedTags, setSelectedTags] = useState<Set<string>>(new Set());
391-
const [minFixabilityScore, setMinFixabilityScore] = useState(50);
392380
const [removedClusterIds, setRemovedClusterIds] = useState(new Set<number>());
393381
const [showJsonInput, setShowJsonInput] = useState(false);
394382
const [jsonInputValue, setJsonInputValue] = useState('');
@@ -516,9 +504,6 @@ function DynamicGrouping() {
516504
.filter(cluster => {
517505
if (removedClusterIds.has(cluster.cluster_id)) return false;
518506

519-
const fixabilityScore = (cluster.fixability_score ?? 0) * 100;
520-
if (fixabilityScore < minFixabilityScore) return false;
521-
522507
// Filter by selected tags
523508
if (!clusterHasSelectedTags(cluster)) return false;
524509

@@ -719,20 +704,6 @@ function DynamicGrouping() {
719704
</Flex>
720705
</Flex>
721706
)}
722-
723-
<Flex gap="sm" align="center">
724-
<Text size="sm" variant="muted">
725-
{t('Minimum fixability score (%)')}
726-
</Text>
727-
<NumberInput
728-
min={0}
729-
max={100}
730-
value={minFixabilityScore}
731-
onChange={value => setMinFixabilityScore(value ?? 0)}
732-
aria-label={t('Minimum fixability score')}
733-
size="sm"
734-
/>
735-
</Flex>
736707
</Flex>
737708
</Disclosure.Content>
738709
</Disclosure>
@@ -864,27 +835,6 @@ const EventsCount = styled('span')`
864835
font-variant-numeric: tabular-nums;
865836
`;
866837

867-
const FixabilityIndicator = styled('div')<{score: number}>`
868-
display: flex;
869-
flex-direction: column;
870-
align-items: center;
871-
padding: ${space(0.75)} ${space(1.5)};
872-
background: ${p =>
873-
p.score >= 0.7
874-
? p.theme.green100
875-
: p.score >= 0.4
876-
? p.theme.yellow100
877-
: p.theme.gray100};
878-
border-radius: ${p => p.theme.borderRadius};
879-
color: ${p =>
880-
p.score >= 0.7
881-
? p.theme.green400
882-
: p.score >= 0.4
883-
? p.theme.yellow400
884-
: p.theme.gray400};
885-
line-height: 1.2;
886-
`;
887-
888838
const SecondaryStats = styled('div')`
889839
display: flex;
890840
gap: ${space(3)};

0 commit comments

Comments
 (0)