fix: Make filename_cache required and remove dead project_root param in Frame

- Make filename_cache a required keyword argument to prevent nil filename
  when it was not provided (the old code defaulted to nil which caused
  compute_filename to return nil via safe navigation operator)
- Remove the dead project_root positional parameter that was no longer
  used after the FilenameCache refactor
- Update all callers to use the new signature

Co-Authored-By: Claude <noreply@anthropic.com>

Author: cursoragent

sentry-ruby/lib/sentry/interfaces/stacktrace.rb

@@ -27,7 +27,7 @@ class Frame < Interface
       attr_accessor :abs_path, :context_line, :function, :in_app, :filename,
                   :lineno, :module, :pre_context, :post_context, :vars
 
-      def initialize(project_root, line, strip_backtrace_load_path = true, filename_cache: nil)
+      def initialize(line, strip_backtrace_load_path: true, filename_cache:)
         @strip_backtrace_load_path = strip_backtrace_load_path
         @filename_cache = filename_cache
 

sentry-ruby/lib/sentry/interfaces/stacktrace_builder.rb

@@ -90,7 +90,7 @@ def build(backtrace:, &frame_callback)
     private
 
     def convert_parsed_line_into_frame(line)
-      frame = StacktraceInterface::Frame.new(project_root, line, strip_backtrace_load_path, filename_cache: @filename_cache)
+      frame = StacktraceInterface::Frame.new(line, strip_backtrace_load_path: strip_backtrace_load_path, filename_cache: @filename_cache)
       frame.set_context(linecache, context_lines) if context_lines
       frame
     end

sentry-ruby/spec/sentry/interfaces/stacktrace_spec.rb

@@ -15,14 +15,14 @@
     let(:filename_cache) { Sentry::FilenameCache.new(configuration.project_root) }
 
     it "initializes a Frame with the correct info from the given Backtrace::Line object" do
-      first_frame = Sentry::StacktraceInterface::Frame.new(configuration.project_root, lines.first, true, filename_cache: filename_cache)
+      first_frame = Sentry::StacktraceInterface::Frame.new(lines.first, strip_backtrace_load_path: true, filename_cache: filename_cache)
 
       expect(first_frame.filename).to match(/base.rb/)
       expect(first_frame.in_app).to eq(false)
       expect(first_frame.function).to eq("save")
       expect(first_frame.lineno).to eq(10)
 
-      second_frame = Sentry::StacktraceInterface::Frame.new(configuration.project_root, lines.last, true, filename_cache: filename_cache)
+      second_frame = Sentry::StacktraceInterface::Frame.new(lines.last, strip_backtrace_load_path: true, filename_cache: filename_cache)
 
       expect(second_frame.filename).to match(/post.rb/)
       expect(second_frame.in_app).to eq(true)
@@ -31,11 +31,11 @@
     end
 
     it "does not strip load path when strip_backtrace_load_path is false" do
-      first_frame = Sentry::StacktraceInterface::Frame.new(configuration.project_root, lines.first, false, filename_cache: filename_cache)
+      first_frame = Sentry::StacktraceInterface::Frame.new(lines.first, strip_backtrace_load_path: false, filename_cache: filename_cache)
       expect(first_frame.filename).to eq(first_frame.abs_path)
       expect(first_frame.filename).to eq(raw_lines.first.split(':').first)
 
-      second_frame = Sentry::StacktraceInterface::Frame.new(configuration.project_root, lines.last, false, filename_cache: filename_cache)
+      second_frame = Sentry::StacktraceInterface::Frame.new(lines.last, strip_backtrace_load_path: false, filename_cache: filename_cache)
       expect(second_frame.filename).to eq(second_frame.abs_path)
       expect(second_frame.filename).to eq(raw_lines.last.split(':').first)
     end

sentry-ruby/spec/sentry/transport_spec.rb

@@ -341,9 +341,8 @@
           new_stacktrace = Sentry::StacktraceInterface.new(
             frames: frame_list_size.times.map do |zero_based_index|
               Sentry::StacktraceInterface::Frame.new(
-                "/fake/path",
                 Sentry::Backtrace::Line.parse("app.rb:#{zero_based_index + 1}:in `/'", in_app_pattern),
-                true,
+                strip_backtrace_load_path: true,
                 filename_cache: Sentry::FilenameCache.new("/fake/path")
               )
             end,