Repository navigation
Commit bfa798f
Read S2's run after P3's joins, counting the chain's units (#614 review)
The review found that reading the trailing run before every join broke
what the corpus never tests: a bare salutation lost its connective to the
family name (`Mr. and Mrs.` -> family 'and'), a joined leading salutation
counted as three words (`Mr. and Mrs. Jr`), and a particle chain or a
connective join counted word by word where rules.md#P3 says a joined part
is one name word (`Freiherr von Berg X.Y.Z.` took the acronym against
every release). Decided by Derek: connectives join first.
- The read now runs after P3's joins and before the particle chain and
the bound-given join, on segments of three or more pieces, and counts a
particle run (duals behind a particle included) with the plain words
after it as one unit, in a copy (`_counting_view`); roman numerals by
shape stay out of the unit (`Juan de la Vega VI`, the #610 class).
`_take_trailing_duals` is gone: the view covers it.
- The chain's S2 emitter reports again where the read did not weigh the
member (`Freiherr von Berg Ed Do` reports 'Ed').
- Restored to master: the P3 group tests, the one-word-gate case row,
`Jane née Jr y Jones` (its ledger rule withdrawn, #418's no longer
dormant). Moves now: `John van der Berg Prof.` (title), P5's
`abdul J. V` (1.4.0's reading), report wording, one garbage fallback.
- New tests, each killed by a recorded mutation: salutation, unit-count,
numeral, dual-at-the-head, contiguity and fallback rows; direct tests of
`read_trailing_run`; group tests of `tail_reads` and the narrowed
emitter. P5 tests renamed to what they assert.
- Docs: S2/P2/P5/H5 statements, the decisions entry (the first design
and its reversal, recipe with draw mechanics, residuals), P3/P5/H5/P2
and parse-cost bullets, mechanisms, release log narrowed to what holds
behind a comma, AGENTS.md's sweep lesson. Frames 317 -> 309 (3.11),
296 -> 290 (3.12-3.15) against adf6da8; segments under three pieces
unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent 7ed94d5 commit bfa798f
21 files changed
Lines changed: 497 additions & 347 deletions
File tree
- docs
- design
- nameparser/_pipeline
- tests/v2
- pipeline
- tools/differential
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
329 | 329 | | |
330 | 330 | | |
331 | 331 | | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| |||
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
454 | | - | |
455 | | - | |
456 | | - | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
457 | 458 | | |
458 | 459 | | |
459 | 460 | | |
| |||
723 | 724 | | |
724 | 725 | | |
725 | 726 | | |
726 | | - | |
727 | | - | |
728 | | - | |
| 727 | + | |
| 728 | + | |
729 | 729 | | |
730 | 730 | | |
731 | 731 | | |
| |||
1026 | 1026 | | |
1027 | 1027 | | |
1028 | 1028 | | |
1029 | | - | |
1030 | | - | |
1031 | | - | |
1032 | | - | |
1033 | | - | |
1034 | | - | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
1035 | 1036 | | |
1036 | 1037 | | |
1037 | 1038 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
371 | 372 | | |
372 | 373 | | |
373 | 374 | | |
374 | | - | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
375 | 380 | | |
376 | 381 | | |
377 | 382 | | |
| |||
0 commit comments