fix: 🐛 node fetch issue resolved

uttamukkoji · uttamukkoji · commit b9f24538a110 · 2021-04-16T11:25:16.000+05:30
diff --git a/dist/nativescript/contentstack.js b/dist/nativescript/contentstack.js
diff --git a/dist/react-native/contentstack.js b/dist/react-native/contentstack.js
diff --git a/dist/web/contentstack.js b/dist/web/contentstack.js
diff --git a/examples/node/contentstack-demo.js b/examples/node/contentstack-demo.js
@@ -15,7 +15,6 @@ class ContentstackDemo {
             //console.log("datattatata", Contentstack.Region.EUROPE)
 
         this.Stack = Contentstack.Stack(...config);
-        console.log(Contentstack.Utils.render());
     }
     
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "contentstack",
-  "version": "3.13.0",
+  "version": "3.13.1",
   "description": "Contentstack Javascript SDK",
   "homepage": "https://www.contentstack.com/",
   "author": {
@@ -22,7 +22,8 @@
     "buildnativescript": "webpack --config webpack/webpack.nativescript.js",
     "build": "NODE_ENV=production && npm run buildnode && npm run buildweb && npm run buildreactnative && npm run buildnativescript",
     "generate-docs": "node_modules/.bin/jsdoc --configure docs-config.json --verbose",
-    "prepare": "npm run build"
+    "prepare": "npm run build",
+    "pretest": "npm run build"
   },
   "repository": {
     "type": "git",
@@ -99,7 +100,7 @@
   "dependencies": {
     "@contentstack/utils": "1.0.0",
     "es6-promise": "4.1.1",
-    "localStorage": "1.0.3",
-    "node-fetch": "^2.6.1"
+    "isomorphic-fetch": "^3.0.0",
+    "localStorage": "1.0.3"
   }
 }
diff --git a/src/core/lib/request.js b/src/core/lib/request.js
@@ -61,7 +61,7 @@ async function safeParseJSON(response) {
     const body = await response.text();
 }
 function fetchRetry(url, headers, retryDelay = 300, retryLimit = 5, fetchOptions, resolve, reject) {
-    var option = Object.assign({ 
+    var option = Utils.mergeDeep({ 
         method: 'GET',
         headers: headers,
         timeout: 30000,                                
diff --git a/src/core/lib/utils.js b/src/core/lib/utils.js
@@ -238,9 +238,7 @@ export function sendRequest(queryObject, options) {
     let tojson = (typeof self.tojson !== 'undefined') ? self.tojson : false;
     let isSingle = (self.entry_uid || self.singleEntry || self.asset_uid) ? true : false;
     let hashQuery = getHash(parseQueryFromParams(self, isSingle, tojson));
-    if (queryObject.requestParams.url.includes(config.urls.sync)) {
-        cachePolicy = -1;
-    }
+
     /**
     for new api v3
     */
diff --git a/src/core/modules/assets.js b/src/core/modules/assets.js
@@ -118,7 +118,7 @@ export default class Assets {
                     query: this._query
                 }
             }
-            var options = Object.assign({}, this.fetchOptions, fetchOptions);
+            var options = Utils.mergeDeep({}, this.fetchOptions, fetchOptions);
             return Utils.sendRequest(this, options);
         } else {
             console.error("Kindly provide an asset uid. e.g. .Assets('bltsomething123')");
diff --git a/src/core/modules/entry.js b/src/core/modules/entry.js
@@ -341,7 +341,7 @@ export default class Entry {
                     query: this._query
                 }
             };
-            var options = Object.assign({}, this.fetchOptions, fetchOptions);
+            var options = Utils.mergeDeep({}, this.fetchOptions, fetchOptions);
             return Utils.sendRequest(this, options);
         } else {
             console.error("Kindly provide an entry uid. e.g. .Entry('bltsomething123')");
diff --git a/src/core/modules/query.js b/src/core/modules/query.js
@@ -757,7 +757,7 @@ export default class Query extends Entry {
                 query: this._query
             }
         };
-        var options = Object.assign({}, this.fetchOptions, fetchOptions);
+        var options = Utils.mergeDeep({}, this.fetchOptions, fetchOptions);
         return Utils.sendRequest(this, options);
     }
 
@@ -790,7 +790,7 @@ export default class Query extends Entry {
                 query: this._query
             }
         };
-        var options = Object.assign({}, this.fetchOptions);
+        var options = Utils.mergeDeep({}, this.fetchOptions);
         return Utils.sendRequest(this, options);
     }
 
diff --git a/src/runtime/web/http.js b/src/runtime/web/http.js
@@ -1,6 +1,5 @@
 import ES6Promise from 'es6-promise';
-import fetch from 'node-fetch';
-
+import fetch from 'isomorphic-fetch';
 ES6Promise.polyfill();
 
 export default fetch;
diff --git a/src/runtime/web/localstorage.js b/src/runtime/web/localstorage.js
@@ -1,16 +1,16 @@
-// export default window.localStorage;
+export default window.localStorage;
 
-let webLocalStoreage = function (){
-    try {
-        var storage = window.localStorage
-        // x = '__storage_test__';
-        // storage.setItem(x, x);
-        // storage.removeItem(x);
-        return storage;
-    } catch(e) {
-        return null
-    }
-};
+// let webLocalStoreage = function (){
+//     try {
+//         var storage = window.localStorage
+//         // x = '__storage_test__';
+//         // storage.setItem(x, x);
+//         // storage.removeItem(x);
+//         return storage;
+//     } catch(e) {
+//         return null
+//     }
+// };
 
-export default webLocalStoreage();
+// export default webLocalStoreage();
     

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ class ContentstackDemo {`
`15`	`15`	`//console.log("datattatata", Contentstack.Region.EUROPE)`
`16`	`16`
`17`	`17`	`this.Stack = Contentstack.Stack(...config);`
`18`		`- console.log(Contentstack.Utils.render());`
`19`	`18`	`}`
`20`	`19`
`21`	`20`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ async function safeParseJSON(response) {`
`61`	`61`	`const body = await response.text();`
`62`	`62`	`}`
`63`	`63`	`function fetchRetry(url, headers, retryDelay = 300, retryLimit = 5, fetchOptions, resolve, reject) {`
`64`		`- var option = Object.assign({`
	`64`	`+ var option = Utils.mergeDeep({`
`65`	`65`	`method: 'GET',`
`66`	`66`	`headers: headers,`
`67`	`67`	`timeout: 30000,`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ export default class Assets {`
`118`	`118`	`query: this._query`
`119`	`119`	`}`
`120`	`120`	`}`
`121`		`- var options = Object.assign({}, this.fetchOptions, fetchOptions);`
	`121`	`+ var options = Utils.mergeDeep({}, this.fetchOptions, fetchOptions);`
`122`	`122`	`return Utils.sendRequest(this, options);`
`123`	`123`	`} else {`
`124`	`124`	`console.error("Kindly provide an asset uid. e.g. .Assets('bltsomething123')");`
Original file line number	Diff line number	Diff line change
`@@ -341,7 +341,7 @@ export default class Entry {`
`341`	`341`	`query: this._query`
`342`	`342`	`}`
`343`	`343`	`};`
`344`		`- var options = Object.assign({}, this.fetchOptions, fetchOptions);`
	`344`	`+ var options = Utils.mergeDeep({}, this.fetchOptions, fetchOptions);`
`345`	`345`	`return Utils.sendRequest(this, options);`
`346`	`346`	`} else {`
`347`	`347`	`console.error("Kindly provide an entry uid. e.g. .Entry('bltsomething123')");`