From 9888be7f96ed41c4c6cd27ffe8f3e6abf01a61de Mon Sep 17 00:00:00 2001 From: Dmitri Plotnikov Date: Wed, 6 May 2026 16:59:17 -0700 Subject: [PATCH] Skip timezone related conformance tests on Windows only PiperOrigin-RevId: 911626528 --- conformance/conformance_test.py | 7 +++++-- custom_ext/BUILD | 5 ++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/conformance/conformance_test.py b/conformance/conformance_test.py index 9d25e64..7f55355 100644 --- a/conformance/conformance_test.py +++ b/conformance/conformance_test.py @@ -73,10 +73,13 @@ class ConformanceTestSuite(unittest.TestSuite): "optionals/optionals/optional_struct_optindex_index_value", "optionals/optionals/optional_struct_optindex_value", "optionals/optionals/struct_optindex_value", - # TODO(b/507568865): Timezone support on Windows. - "timestamps/timestamp_selectors_tz/.*", ] + if os.name == "nt": + # TODO(b/507568865): These tests depend on configuring a timezone database + # which isn't available in our windows test environment. + SKIP_TESTS.append("timestamps/timestamp_selectors_tz/.*") + def __init__(self): super().__init__(self) self._load_tests() diff --git a/custom_ext/BUILD b/custom_ext/BUILD index 1718513..2329467 100644 --- a/custom_ext/BUILD +++ b/custom_ext/BUILD @@ -36,7 +36,10 @@ py_library( data = [ "//cel_expr_python:cel", ], - deps = ["//cel_expr_python:cel"], + deps = select({ + "@platforms//os:windows": [], + "//conditions:default": ["//cel_expr_python:cel"], + }), ) py_test(