From 6e7dbe75ef0f6d52d5d689b4684f6d893728cb8f Mon Sep 17 00:00:00 2001 From: Sean Huh Date: Mon, 16 Nov 2026 11:16:15 -0800 Subject: [PATCH] Document SelectOptimizer limitations and fail fast on json_name ASTs PiperOrigin-RevId: 1022969002 --- .../optimizer/optimizers/SelectOptimizer.java | 16 +++++- .../optimizers/SelectOptimizerTest.java | 49 +++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/optimizer/src/main/java/dev/cel/optimizer/optimizers/SelectOptimizer.java b/optimizer/src/main/java/dev/cel/optimizer/optimizers/SelectOptimizer.java index 973c96f72..70b81fa02 100644 --- a/optimizer/src/main/java/dev/cel/optimizer/optimizers/SelectOptimizer.java +++ b/optimizer/src/main/java/dev/cel/optimizer/optimizers/SelectOptimizer.java @@ -137,11 +137,16 @@ * *

Dynamic or trailing indices and non-protobuf selects pass through untouched. * + *

Optimizer Ordering: Run {@code SelectOptimizer} last, after {@link + * ConstantFoldingOptimizer}, {@link InliningOptimizer}, and {@link SubexpressionOptimizer}, which + * operate on unoptimized {@code select} nodes. + * *

Limitations: * *