From 690cb06bac667489fc262df12fe984c2a883e153 Mon Sep 17 00:00:00 2001 From: Lisa Julia Nebel Date: Thu, 18 Jun 2026 14:38:58 +0200 Subject: [PATCH] Fix one sonarqube issue apart from the coverage --- .../cds/feature/recommendation/api/RptInferenceClient.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cds-feature-recommendations/src/main/java/com/sap/cds/feature/recommendation/api/RptInferenceClient.java b/cds-feature-recommendations/src/main/java/com/sap/cds/feature/recommendation/api/RptInferenceClient.java index c3e3c43..1af7384 100644 --- a/cds-feature-recommendations/src/main/java/com/sap/cds/feature/recommendation/api/RptInferenceClient.java +++ b/cds-feature-recommendations/src/main/java/com/sap/cds/feature/recommendation/api/RptInferenceClient.java @@ -54,7 +54,7 @@ public class RptInferenceClient implements RecommendationClient { private static final Logger logger = LoggerFactory.getLogger(RptInferenceClient.class); // RPT-1 specific: the placeholder value that marks a column as a prediction target in the request - public static final String PREDICT = "[PREDICT]"; + public static final String PREDICTION_PLACEHOLDER = "[PREDICT]"; private static final Retry INFERENCE_RETRY = buildInferenceRetry(); @@ -111,7 +111,7 @@ static String computeSyntheticKey(Map row, List keyNames private static CdsData preparePredictRow(CdsData predictRow, List predictionColumns) { Map preparedPredictRowMap = new HashMap<>(predictRow); for (String col : predictionColumns) { - preparedPredictRowMap.putIfAbsent(col, PREDICT); + preparedPredictRowMap.putIfAbsent(col, PREDICTION_PLACEHOLDER); } return CdsData.create(preparedPredictRowMap); } @@ -127,7 +127,7 @@ private static PredictRequestPayload buildRequest( col -> TargetColumnConfig.create() .name(col) - .predictionPlaceholder(PredictionPlaceholder.create(PREDICT)) + .predictionPlaceholder(PredictionPlaceholder.create(PREDICTION_PLACEHOLDER)) .taskType(TargetColumnConfig.TaskTypeEnum.CLASSIFICATION)) .toList();