From df73303c6b6610df40d93a9e0b675d5baaff3691 Mon Sep 17 00:00:00 2001 From: Hunter Garrett Date: Fri, 28 Aug 2026 18:20:56 -0400 Subject: [PATCH] ci: run root vp check and drop persisted credentials (BON-18, BON-19) Root vp check, the command in the CLAUDE.md review checklist, failed on main because apps/docs/components/logo.tsx was never formatted. The two other files BON-18 listed were fixed by later PRs. CI never caught it: the per-app check jobs run tsc, and only the bones package runs vp check. A new "Repo: Format & Lint" job runs vp check from the root, so format and lint cover every package and app. The per-app tsc jobs stay. Every checkout step in ci.yml now sets persist-credentials: false. No job there runs authenticated git after checkout. release.yml keeps the default because changesets/action pushes the version branch and the release step pushes the tag. Co-Authored-By: Claude Fable 5 --- .github/workflows/ci.yml | 46 +++++++++++++++++++++++++++++++++++ apps/docs/components/logo.tsx | 7 +----- 2 files changed, 47 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6cadcb7..87844be 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,6 +10,24 @@ permissions: contents: read jobs: + # ── Whole repo ───────────────────────────────────────────── + repo-check: + name: "Repo: Format & Lint" + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v4 + with: + persist-credentials: false + + - name: Setup Vite+ + uses: voidzero-dev/setup-vp@v1 + with: + cache: true + + - name: Run format and lint checks across the workspace + run: vp check + # ── Bones library ────────────────────────────────────────── bones-check: name: "Bones: Lint, Format & Types" @@ -17,6 +35,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -32,6 +52,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -47,6 +69,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -62,6 +86,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -91,6 +117,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -109,6 +137,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -127,6 +157,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -146,6 +178,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -164,6 +198,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -183,6 +219,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -201,6 +239,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -219,6 +259,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -235,6 +277,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 @@ -253,6 +297,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: Setup Vite+ uses: voidzero-dev/setup-vp@v1 diff --git a/apps/docs/components/logo.tsx b/apps/docs/components/logo.tsx index 30c9bad..0db4c08 100644 --- a/apps/docs/components/logo.tsx +++ b/apps/docs/components/logo.tsx @@ -1,11 +1,6 @@ export function Logo(props: React.SVGProps) { return ( - +