refactor: remove unused exclude_packages from npm_install & yarn_install

gregmagolan · alexeagle · commit f50dea315cff · 2019-12-17T09:07:53.000-08:00
BREAKING CHANGE:
Removed unused exclude_packages from npm_install &amp; yarn_install
diff --git a/e2e/ts_devserver/WORKSPACE b/e2e/ts_devserver/WORKSPACE
@@ -52,4 +52,7 @@ web_test_repositories()
 
 load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories")
 
-browser_repositories(chromium = True)
+browser_repositories(
+    chromium = True,
+    firefox = True,
+)
diff --git a/examples/app/WORKSPACE b/examples/app/WORKSPACE
@@ -52,4 +52,7 @@ web_test_repositories()
 
 load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories")
 
-browser_repositories(chromium = True)
+browser_repositories(
+    chromium = True,
+    firefox = True,
+)
diff --git a/examples/web_testing/WORKSPACE b/examples/web_testing/WORKSPACE
@@ -47,7 +47,10 @@ web_test_repositories()
 
 load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories")
 
-browser_repositories(chromium = True)
+browser_repositories(
+    chromium = True,
+    firefox = True,
+)
 
 load("@npm_bazel_typescript//:index.bzl", "ts_setup_workspace")
 
diff --git a/examples/webapp/WORKSPACE b/examples/webapp/WORKSPACE
@@ -48,4 +48,7 @@ web_test_repositories()
 
 load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories")
 
-browser_repositories(chromium = True)
+browser_repositories(
+    chromium = True,
+    firefox = True,
+)
diff --git a/internal/npm_install/npm_install.bzl b/internal/npm_install/npm_install.bzl
@@ -66,9 +66,6 @@ If symlink_node_modules is True, this attribute is ignored since
 the dependency manager will run in the package.json location.
 """,
     ),
-    "exclude_packages": attr.string_list(
-        doc = """DEPRECATED. This attribute is no longer used.""",
-    ),
     "included_files": attr.string_list(
         doc = """List of file extensions to be included in the npm package targets.
 
diff --git a/packages/karma/docs/install.md b/packages/karma/docs/install.md
@@ -34,7 +34,10 @@ web_test_repositories()
 
 load("@io_bazel_rules_webtesting//web/versioned:browsers-0.3.2.bzl", "browser_repositories")
 
-browser_repositories(chromium = True)
+browser_repositories(
+    chromium = True,
+    firefox = True,
+)
 ```
 
 ## Installing with self-managed dependencies
