Skip to content

Commit ea168a7

Browse files
lencionialexeagle
authored andcommitted
fix(typescript): allow up to typescript 4.2, add tests for 3.7-4.1
This commit relaxes the semver range of the typescript peerDependency to allow for v4.2 and earlier. I chose this version because 4.1 has been released, and we are expecting 4.2 to be released soon. TypeScript does not follow semver, so this could probably be a bit higher, but for now this is an improvement over the current range. To support this, I added some e2e tests for some of the newer versions that are now covered in the new semver range. This should help ensure that we don't break anyone using these versions as changes are made.
1 parent 7ebfd1d commit ea168a7

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

e2e/BUILD.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,4 +137,9 @@ e2e_integration_test(
137137
"3.4.x",
138138
"3.5.x",
139139
"3.6.x",
140+
"3.7.x",
141+
"3.8.x",
142+
"3.9.x",
143+
"4.0.x",
144+
"4.1.x",
140145
]]

packages/typescript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
},
2424
"//": "note that typescript doesn't follow semver, so technically anything 3.6 or higher might break us",
2525
"peerDependencies": {
26-
"typescript": ">=3.0.0 <4.0"
26+
"typescript": ">=3.0.0 <4.3"
2727
},
2828
"dependencies": {
2929
"protobufjs": "6.8.8",

0 commit comments

Comments
 (0)