fix(typescript): add .proto files from npm deps to inputs of ts_library (#1991)

gregmagolan · web-flow · commit c1d4885e62e0 · 2020-07-01T08:49:32.000-07:00
If @bazel/typescript is a dep of ts_library then the linker needs to include 'third_party/github.com/bazelbuild/bazel/src/main/protobuf/worker_protocol.proto' as an input as worker.js will run out of node_modules. The failure was only observed on Angular repo RBE since running ts_library has workers on by default it is not sandboxed.
diff --git a/packages/typescript/internal/build_defs.bzl b/packages/typescript/internal/build_defs.bzl
@@ -104,7 +104,7 @@ def _filter_ts_inputs(all_inputs):
     return [
         f
         for f in all_inputs
-        if f.extension in ["js", "jsx", "ts", "tsx", "json"]
+        if f.extension in ["js", "jsx", "ts", "tsx", "json", "proto"]
     ]
 
 def _compile_action(ctx, inputs, outputs, tsconfig_file, node_opts, description = "prodmode"):

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ def _filter_ts_inputs(all_inputs):`
`104`	`104`	`return [`
`105`	`105`	`f`
`106`	`106`	`for f in all_inputs`
`107`		`- if f.extension in ["js", "jsx", "ts", "tsx", "json"]`
	`107`	`+ if f.extension in ["js", "jsx", "ts", "tsx", "json", "proto"]`
`108`	`108`	`]`
`109`	`109`
`110`	`110`	`def _compile_action(ctx, inputs, outputs, tsconfig_file, node_opts, description = "prodmode"):`