Skip to content

Commit bb2a302

Browse files
authored
fix: remove jasmine-core as a peer dep (#2336)
1 parent df4b9f1 commit bb2a302

7 files changed

Lines changed: 0 additions & 8 deletions

File tree

examples/angular/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@
5656
"history-server": "^1.3.1",
5757
"html-insert-assets": "^0.6.0",
5858
"jasmine": "2.8.0",
59-
"jasmine-core": "2.8.0",
6059
"karma": "~4.1.0",
6160
"karma-chrome-launcher": "2.2.0",
6261
"karma-firefox-launcher": "1.1.0",

examples/angular_bazel_architect/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"@types/node": "12.12.6",
4343
"codelyzer": "^6.0.0",
4444
"html-webpack-plugin": "^3.2.0",
45-
"jasmine-core": "~3.5.0",
4645
"jasmine-spec-reporter": "~5.0.0",
4746
"karma": "~5.0.0",
4847
"karma-chrome-launcher": "~3.1.0",

examples/angular_view_engine/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"history-server": "^1.3.1",
5151
"html-insert-assets": "^0.6.0",
5252
"jasmine": "2.8.0",
53-
"jasmine-core": "2.8.0",
5453
"karma": "~4.1.0",
5554
"karma-chrome-launcher": "2.2.0",
5655
"karma-firefox-launcher": "1.1.0",

examples/protocol_buffers/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"grpc-web": "1.1.0",
1616
"http-server": "^0.11.1",
1717
"jasmine": "2.8.0",
18-
"jasmine-core": "2.8.0",
1918
"karma": "~4.1.0",
2019
"karma-chrome-launcher": "2.2.0",
2120
"karma-firefox-launcher": "1.1.0",

examples/web_testing/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"@bazel/typescript": "^2.2.2",
55
"@types/jasmine": "2.8.2",
66
"@types/node": "11.11.1",
7-
"jasmine-core": "^3.3.0",
87
"karma": "~4.1.0",
98
"karma-chrome-launcher": "2.2.0",
109
"karma-firefox-launcher": "1.1.0",

packages/concatjs/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"tsutils": "2.27.2"
2323
},
2424
"peerDependencies": {
25-
"jasmine-core": ">=2.0.0",
2625
"karma": ">=4.0.0",
2726
"karma-chrome-launcher": ">=2.0.0",
2827
"karma-firefox-launcher": ">=1.0.0",

packages/concatjs/web_test/karma_web_test.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ load("@io_bazel_rules_webtesting//web/internal:constants.bzl", "DEFAULT_WRAPPED_
2121
KARMA_PEER_DEPS = [
2222
# NB: uncommented during pkg_npm
2323
#@external "@npm//@bazel/concatjs",
24-
"@npm//jasmine-core",
2524
"@npm//karma",
2625
"@npm//karma-chrome-launcher",
2726
"@npm//karma-firefox-launcher",
@@ -132,7 +131,6 @@ def _write_karma_config(ctx, files, amd_names_shim):
132131
# The files in the bootstrap attribute come before the require.js support.
133132
# Note that due to frameworks = ['jasmine'], a few scripts will come before
134133
# the bootstrap entries:
135-
# jasmine-core/lib/jasmine-core/jasmine.js
136134
# karma-jasmine/lib/boot.js
137135
# karma-jasmine/lib/adapter.js
138136
# This is desired so that the bootstrap entries can patch jasmine, as zone.js does.

0 commit comments

Comments
 (0)