Skip to content

Commit 7708858

Browse files
committed
fix(jasmine): enforce that jasmine_node_test is loaded from new location
BREAKING CHANGE: You can no longer get jasmine_node_test from @build_bazel_rules_nodejs. - Use `load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")` instead - You need to remove `@npm//jasmine` from the deps of the jasmine_node_test - If you use user-managed dependencies, see the commit for examples of the change needed Also makes the repo bazel-lint-clean, so running yarn bazel:lint-fix no longer makes edits. Fixes #838
1 parent 432f88c commit 7708858

74 files changed

Lines changed: 2711 additions & 888 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docs/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ skylark_doc(
2020
"//internal/common:check_bazel_version.bzl",
2121
"//internal/history-server:history_server.bzl",
2222
"//internal/http-server:http_server.bzl",
23-
"//internal/jasmine_node_test:jasmine_node_test.bzl",
2423
"//internal/node:node.bzl",
2524
"//internal/node:node_repositories.bzl",
2625
"//internal/npm_install:npm_install.bzl",

docs/common/check_bazel_version.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>

docs/history-server/history_server.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>

docs/http-server/http_server.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>

docs/index.html

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>
@@ -120,7 +114,6 @@ <h2>Rule sets</h2>
120114
<li><a href="#check_bazel_version">Check Bazel version</a></li>
121115
<li><a href="#history_server">Run history-server</a></li>
122116
<li><a href="#http_server">Run http-server</a></li>
123-
<li><a href="#jasmine_node_test">NodeJS testing</a></li>
124117
<li><a href="#node">Executing programs</a></li>
125118
<li><a href="#node_repositories">Install NodeJS & Yarn</a></li>
126119
<li><a href="#npm_install">Install npm packages</a></li>
@@ -206,28 +199,6 @@ <h3>Macros</h3>
206199
</tr>
207200
</tbody>
208201
</table>
209-
<h2><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html" id="jasmine_node_test">NodeJS testing</a></h2>
210-
211-
<h3>Macros</h3>
212-
<table class="overview-table">
213-
<colgroup>
214-
<col class="col-name" />
215-
<col class="col-description" />
216-
</colgroup>
217-
<tbody>
218-
<tr>
219-
<td>
220-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#jasmine_node_test">
221-
<code>jasmine_node_test</code>
222-
</a>
223-
</td>
224-
<td>
225-
<p>Runs tests in NodeJS using the Jasmine test runner.</p>
226-
227-
</td>
228-
</tr>
229-
</tbody>
230-
</table>
231202
<h2><a href="/rules_nodejs/node/node.html" id="node">Executing programs</a></h2>
232203

233204
<h3>Rules</h3>

docs/jasmine_node_test/jasmine_node_test.html

Lines changed: 0 additions & 213 deletions
This file was deleted.

docs/node/node.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>

docs/node/node_repositories.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>

docs/npm_install/npm_install.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>

docs/npm_package/npm_package.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@
4848
<ul>
4949
</ul>
5050
</li>
51-
<li>
52-
<a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html">NodeJS testing</a>
53-
<ul>
54-
<li><a href="/rules_nodejs/jasmine_node_test/jasmine_node_test.html#overview">Overview</a></li>
55-
</ul>
56-
</li>
5751
<li>
5852
<a href="/rules_nodejs/node/node.html">Executing programs</a>
5953
<ul>

0 commit comments

Comments
 (0)