Skip to content

Commit 6dc919d

Browse files
Fabian Wilesgregmagolan
Fabian Wiles
authored and
gregmagolan
committed
feat(examples): add angular bazel architect
1 parent 7d7f85a commit 6dc919d

39 files changed

Lines changed: 10746 additions & 2 deletions

‎.bazelrc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import %workspace%/common.bazelrc
55
# This lets us glob() up all the files inside the examples to make them inputs to tests
66
# To update these lines, just run `yarn bazel:update-deleted-packages`
77
# (Note, we cannot use common --deleted_packages because the bazel version command doesn't support it)
8-
build --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/hello-world,examples/angular/src/app/todos/reducers,examples/angular/src/app/todos,examples/angular/src/app/home,examples/angular/src/app,examples/angular/src/shared/material,examples/angular/src/assets,examples/angular/src,examples/angular/src/lib/shorten,examples/angular/tools,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/assets,examples/angular_view_engine/src,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/tools,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/jest,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node_and_yarn,examples/vendored_node,examples/webapp,examples/web_testing,examples/worker,e2e/bazel_managed_deps,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp
9-
query --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/hello-world,examples/angular/src/app/todos/reducers,examples/angular/src/app/todos,examples/angular/src/app/home,examples/angular/src/app,examples/angular/src/shared/material,examples/angular/src/assets,examples/angular/src,examples/angular/src/lib/shorten,examples/angular/tools,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/assets,examples/angular_view_engine/src,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/tools,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/jest,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node_and_yarn,examples/vendored_node,examples/webapp,examples/web_testing,examples/worker,e2e/bazel_managed_deps,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp
8+
build --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/hello-world,examples/angular/src/app/todos/reducers,examples/angular/src/app/todos,examples/angular/src/app/home,examples/angular/src/app,examples/angular/src/shared/material,examples/angular/src/assets,examples/angular/src,examples/angular/src/lib/shorten,examples/angular/tools,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/assets,examples/angular_view_engine/src,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/tools,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/jest,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node_and_yarn,examples/vendored_node,examples/webapp,examples/web_testing,examples/worker,e2e/bazel_managed_deps,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp,examples/angular_bazel_architect
9+
query --deleted_packages=examples/angular,examples/angular/e2e,examples/angular/src/app/hello-world,examples/angular/src/app/todos/reducers,examples/angular/src/app/todos,examples/angular/src/app/home,examples/angular/src/app,examples/angular/src/shared/material,examples/angular/src/assets,examples/angular/src,examples/angular/src/lib/shorten,examples/angular/tools,examples/angular_view_engine,examples/angular_view_engine/e2e,examples/angular_view_engine/src/app/hello-world,examples/angular_view_engine/src/app/todos/reducers,examples/angular_view_engine/src/app/todos,examples/angular_view_engine/src/app/home,examples/angular_view_engine/src/app,examples/angular_view_engine/src/shared/material,examples/angular_view_engine/src/assets,examples/angular_view_engine/src,examples/angular_view_engine/src/lib/shorten,examples/angular_view_engine/tools,examples/app,examples/app/styles,examples/app/test,examples/closure,examples/jest,examples/kotlin,examples/nestjs,examples/nestjs/src,examples/parcel,examples/protocol_buffers,examples/react_webpack,examples/user_managed_deps,examples/vendored_node_and_yarn,examples/vendored_node,examples/webapp,examples/web_testing,examples/worker,e2e/bazel_managed_deps,e2e/fine_grained_symlinks,e2e/jasmine,e2e/node_loader_no_preserve_symlinks,e2e/node_loader_preserve_symlinks,e2e/packages,e2e/symlinked_node_modules_npm,e2e/symlinked_node_modules_yarn,e2e/ts_devserver,e2e/ts_devserver/genrule,e2e/ts_devserver/subpackage,e2e/typescript,e2e/webapp,examples/angular_bazel_architect
1010

1111
# Mock versioning command to test the --stamp behavior
1212
build --workspace_status_command="echo BUILD_SCM_VERSION 1.2.3"

‎.circleci/config.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@
1010
## IMPORTANT
1111
# If you change the `default_docker_image` version, also change the `cache_key` version
1212
var_1: &default_docker_image circleci/node:10.16
13+
var_2: &browsers_docker_image circleci/node:10.16-browsers
1314
var_3: &cache_key node-0.16-{{ checksum "yarn.lock" }}-v2
1415

16+
1517
var_4: &init_environment
1618
run:
1719
name: Initializing environment (setting up variables, overwriting Yarn)
@@ -185,6 +187,9 @@ jobs:
185187

186188
test_examples:
187189
<<: *job_defaults
190+
docker:
191+
# Needed because some tests require local chrome
192+
- image: *browsers_docker_image
188193
resource_class: xlarge
189194
# We need to reduce the memory & CPU usage of the top-level
190195
# bazel process for this large bazel-in-bazel test to not

‎examples/BUILD.bazel‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,3 +200,13 @@ example_integration_test(
200200
],
201201
npm_packages = {"//packages/worker:npm_package": "@bazel/worker"},
202202
)
203+
204+
example_integration_test(
205+
name = "examples_angular_bazel_architect",
206+
bazel_commands = [
207+
"test ...",
208+
],
209+
npm_packages = {},
210+
# windows fails CI with an error to do with a process fork not being able ot find node
211+
tags = ["fix-windows"],
212+
)

‎examples/angular_bazel_architect/.bazelignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
node_modules

‎examples/angular_bazel_architect/.bazelrc‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import %workspace%/../../common.bazelrc
2+
3+
# The Angular CLI will by default try to write to a cache, but under Bazel it's a read only fs
4+
# so we need to disable it with this env var
5+
build --define=NG_BUILD_CACHE=false

‎examples/angular_bazel_architect/.gitignore‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# See http://help.github.com/ignore-files/ for more about ignoring files.
2+
3+
# compiled output
4+
/dist
5+
/tmp
6+
/out-tsc
7+
# Only exists if Bazel was run
8+
/bazel-out
9+
10+
# dependencies
11+
/node_modules
12+
13+
# profiling files
14+
chrome-profiler-events*.json
15+
speed-measure-plugin*.json
16+
17+
# IDEs and editors
18+
/.idea
19+
.project
20+
.classpath
21+
.c9/
22+
*.launch
23+
.settings/
24+
*.sublime-workspace
25+
26+
# IDE - VSCode
27+
.vscode/*
28+
!.vscode/settings.json
29+
!.vscode/tasks.json
30+
!.vscode/launch.json
31+
!.vscode/extensions.json
32+
.history/*
33+
34+
# misc
35+
/.sass-cache
36+
/connect.lock
37+
/coverage
38+
/libpeerconnection.log
39+
npm-debug.log
40+
yarn-error.log
41+
testem.log
42+
/typings
43+
44+
# System Files
45+
.DS_Store
46+
Thumbs.db

‎examples/angular_bazel_architect/BUILD.bazel‎

Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
1+
load("@npm//@angular-devkit/architect-cli:index.bzl", "architect", "architect_test")
2+
3+
architect(
4+
name = "build",
5+
args = [
6+
"frontend:build",
7+
"--outputPath=$(@D)",
8+
],
9+
configuration_env_vars = ["NG_BUILD_CACHE"],
10+
data = glob(
11+
[
12+
"src/*",
13+
"src/**",
14+
],
15+
exclude = [
16+
"src/**/*.spec.ts",
17+
"src/test.ts",
18+
],
19+
) + [
20+
"angular.json",
21+
"browserslist",
22+
"tsconfig.app.json",
23+
"tsconfig.json",
24+
"@npm//mime",
25+
"@npm//@angular/cli",
26+
"@npm//@angular/core",
27+
"@npm//@angular/router",
28+
"@npm//@angular/platform-browser-dynamic",
29+
"@npm//@angular-devkit/architect-cli",
30+
"@npm//@angular-devkit/build-angular",
31+
],
32+
output_dir = True,
33+
)
34+
35+
architect_test(
36+
name = "test",
37+
args = ["frontend:test"],
38+
configuration_env_vars = ["NG_BUILD_CACHE"],
39+
data = glob([
40+
"src/*",
41+
"src/**",
42+
]) + [
43+
"angular.json",
44+
"karma.conf.js",
45+
"tsconfig.spec.json",
46+
"tsconfig.json",
47+
"@npm//@types/jasmine",
48+
"@npm//@types/node",
49+
"@npm//@angular/cli",
50+
"@npm//@angular/core",
51+
"@npm//@angular/router",
52+
"@npm//@angular/platform-browser-dynamic",
53+
"@npm//@angular-devkit/build-angular",
54+
"@npm//karma",
55+
"@npm//karma-chrome-launcher",
56+
"@npm//karma-coverage-istanbul-reporter",
57+
"@npm//karma-jasmine",
58+
"@npm//karma-jasmine-html-reporter",
59+
],
60+
tags = ["browser:chromium-local"],
61+
)
62+
63+
# Just a dummy test so that we have a test target for //... on certain bazelci platforms with bazel_integration_test
64+
sh_test(
65+
name = "dummy_test",
66+
srcs = ["dummy_test.sh"],
67+
)

‎examples/angular_bazel_architect/README.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Angular Bazel Architect
2+
3+
This project was generated with [Angular CLI](https://github.com/angular/angular-cli)
4+
5+
This example showcases building and testing a project with the Angular CLI.
6+
Instead of using the Angular CLI directly we use Architect here, which is the lower level api for the Angular CLI.
7+
8+
This requies one patch, which can be found under ./patches.
9+
This patch adjusts how the architect-cli prints stdio so that when running under Bazel you don't lose your logs.

‎examples/angular_bazel_architect/WORKSPACE‎

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
# Bazel workspace created by @bazel/create 0.38.1
2+
# Declares that this directory is the root of a Bazel workspace.
3+
# See https://docs.bazel.build/versions/master/build-ref.html#workspace
4+
workspace(
5+
# How this workspace would be referenced with absolute labels from another workspace
6+
name = "angular_cli_demo",
7+
)
8+
9+
# Install the nodejs "bootstrap" package
10+
# This provides the basic tools for running and packaging nodejs programs in Bazel
11+
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
12+
13+
http_archive(
14+
name = "build_bazel_rules_nodejs",
15+
sha256 = "3887b948779431ac443e6a64f31b9e1e17b8d386a31eebc53ec1d9b0a6cabd2b",
16+
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/1.2.0/rules_nodejs-1.2.0.tar.gz"],
17+
)
18+
19+
# The yarn_install rule runs yarn anytime the package.json or yarn.lock file changes.
20+
# It also extracts and installs any Bazel rules distributed in an npm package.
21+
load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
22+
23+
yarn_install(
24+
# Name this npm so that Bazel Label references look like @npm//package
25+
name = "npm",
26+
data = ["//:patches/@angular-devkit+architect-cli+0.900.0-rc.7.patch"],
27+
package_json = "//:package.json",
28+
# Turn off symlink_node_modules here as it causes extreme flakiness on buildkite
29+
# macos CI with missing files in node_modules.
30+
# TODO: track down the root cause of the flakiness; it may be something to
31+
# do with how the Bazel team has setup their macos virtualization.
32+
symlink_node_modules = False,
33+
yarn_lock = "//:yarn.lock",
34+
)
35+
36+
# Install any Bazel rules which were extracted earlier by the yarn_install rule.
37+
load("@npm//:install_bazel_dependencies.bzl", "install_bazel_dependencies")
38+
39+
install_bazel_dependencies()

‎examples/angular_bazel_architect/angular.json‎

Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,132 @@
1+
{
2+
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
3+
"version": 1,
4+
"newProjectRoot": "projects",
5+
"projects": {
6+
"frontend": {
7+
"projectType": "application",
8+
"schematics": {
9+
"@schematics/angular:component": {
10+
"style": "scss"
11+
}
12+
},
13+
"root": "",
14+
"sourceRoot": "src",
15+
"prefix": "app",
16+
"architect": {
17+
"build": {
18+
"builder": "@angular-devkit/build-angular:browser",
19+
"options": {
20+
"preserveSymlinks": true,
21+
"outputPath": "dist/frontend",
22+
"index": "src/index.html",
23+
"main": "src/main.ts",
24+
"polyfills": "src/polyfills.ts",
25+
"tsConfig": "tsconfig.app.json",
26+
"aot": true,
27+
"assets": [
28+
"src/favicon.ico",
29+
"src/assets"
30+
],
31+
"styles": [
32+
"src/styles.scss"
33+
],
34+
"scripts": []
35+
},
36+
"configurations": {
37+
"production": {
38+
"fileReplacements": [
39+
{
40+
"replace": "src/environments/environment.ts",
41+
"with": "src/environments/environment.prod.ts"
42+
}
43+
],
44+
"optimization": true,
45+
"outputHashing": "all",
46+
"sourceMap": false,
47+
"extractCss": true,
48+
"namedChunks": false,
49+
"aot": true,
50+
"extractLicenses": true,
51+
"vendorChunk": false,
52+
"buildOptimizer": true,
53+
"budgets": [
54+
{
55+
"type": "initial",
56+
"maximumWarning": "2mb",
57+
"maximumError": "5mb"
58+
},
59+
{
60+
"type": "anyComponentStyle",
61+
"maximumWarning": "6kb",
62+
"maximumError": "10kb"
63+
}
64+
]
65+
}
66+
}
67+
},
68+
"serve": {
69+
"builder": "@angular-devkit/build-angular:dev-server",
70+
"options": {
71+
"browserTarget": "frontend:build"
72+
},
73+
"configurations": {
74+
"production": {
75+
"browserTarget": "frontend:build:production"
76+
}
77+
}
78+
},
79+
"extract-i18n": {
80+
"builder": "@angular-devkit/build-angular:extract-i18n",
81+
"options": {
82+
"browserTarget": "frontend:build"
83+
}
84+
},
85+
"test": {
86+
"builder": "@angular-devkit/build-angular:karma",
87+
"options": {
88+
"preserveSymlinks": true,
89+
"main": "src/test.ts",
90+
"polyfills": "src/polyfills.ts",
91+
"tsConfig": "tsconfig.spec.json",
92+
"karmaConfig": "karma.conf.js",
93+
"watch": false,
94+
"assets": [
95+
"src/favicon.ico",
96+
"src/assets"
97+
],
98+
"styles": [
99+
"src/styles.scss"
100+
],
101+
"scripts": []
102+
}
103+
},
104+
"lint": {
105+
"builder": "@angular-devkit/build-angular:tslint",
106+
"options": {
107+
"tsConfig": [
108+
"tsconfig.app.json",
109+
"tsconfig.spec.json",
110+
"e2e/tsconfig.json"
111+
],
112+
"exclude": [
113+
"**/node_modules/**"
114+
]
115+
}
116+
},
117+
"e2e": {
118+
"builder": "@angular-devkit/build-angular:protractor",
119+
"options": {
120+
"protractorConfig": "e2e/protractor.conf.js",
121+
"devServerTarget": "frontend:serve"
122+
},
123+
"configurations": {
124+
"production": {
125+
"devServerTarget": "frontend:serve:production"
126+
}
127+
}
128+
}
129+
}
130+
}},
131+
"defaultProject": "frontend"
132+
}

0 commit comments

Comments
 (0)