Skip to content

Commit 065922b

Browse files
Alex Eaglealexeagle
authored andcommitted
fix(typescript): ts_library should accept .tsx inputs
These were accidentally filtered out of the generated tsconfig in 16cbc6f
1 parent e09c2a5 commit 065922b

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/typescript/internal/build_defs.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ def tsc_wrapped_tsconfig(
246246
ctx,
247247
# Filter out package.json files that are included in DeclarationInfo
248248
# tsconfig files=[] property should only be .ts/.d.ts
249-
[f for f in files if f.path.endswith(".ts")],
249+
[f for f in files if f.path.endswith(".ts") or f.path.endswith(".tsx")],
250250
srcs,
251251
devmode_manifest = devmode_manifest,
252252
node_modules_root = node_modules_root,

packages/typescript/test/ts_library_esm_with_jest/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ load(":ts_jest_test.bzl", "ts_jest_test")
55
ts_library(
66
name = "lib",
77
srcs = [
8-
"lib.ts",
8+
"lib.tsx",
99
],
1010
# NB: hacky hidden configuration setting so that es6_sources does not include tsickle
1111
# .externs.js outputs

packages/typescript/test/ts_library_esm_with_jest/lib.ts renamed to packages/typescript/test/ts_library_esm_with_jest/lib.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
export function doStuff(a: string): string {
22
return a
3-
}
3+
}

0 commit comments

Comments
 (0)