fix(jwk): handle KeySet equality with unrelated types (#106)

Author: janmrow

src/joserfc/_keys.py

@@ -124,7 +124,8 @@ def __bool__(self) -> bool:
         return bool(self.keys)
 
     def __eq__(self, other: t.Any) -> bool:
-        assert isinstance(other, KeySet)
+        if not isinstance(other, KeySet):
+            return False
         return self.keys == other.keys
 
     def as_dict(self, private: bool = False, **params: t.Any) -> KeySetSerialization:

tests/jwk/test_jwk_set.py

@@ -103,3 +103,8 @@ def test_key_eq_with_new_keys(self):
         key_set2 = KeySet([RSAKey.import_key(k.as_dict(private=True)) for k in key_set1])
         self.assertIsNot(key_set1, key_set2)
         self.assertEqual(key_set1, key_set2)
+
+    def test_key_set_eq_with_unrelated_type(self):
+        key_set = KeySet.generate_key_set("oct", 8, count=1)
+        self.assertFalse(key_set == "foo")
+        self.assertNotEqual(key_set, "foo")