Skip to content

[fix](Nereids): avoid Exception to cause analyze time too long#23627

Merged
jackwener merged 1 commit into
apache:masterfrom
jackwener:regression
Aug 30, 2023
Merged

[fix](Nereids): avoid Exception to cause analyze time too long#23627
jackwener merged 1 commit into
apache:masterfrom
jackwener:regression

Conversation

@jackwener

@jackwener jackwener commented Aug 29, 2023

Copy link
Copy Markdown
Member

Proposed changes

AnyDataType will cause toCatalogDataType throw Exception, it will cost much time.

Avoid to throw Exception in Analyzer.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jackwener

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.86 seconds
stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162159290 Bytes

Comment on lines +38 to +43
// TODO: resolve AnyDataType invoke toCatalogDataType
if (signatureType instanceof ArrayType) {
if (((ArrayType) signatureType).getItemType() instanceof AnyDataType) {
return false;
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return null /special catalog type for any data type may be better?

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 30, 2023
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@jackwener jackwener merged commit 4fec082 into apache:master Aug 30, 2023
@jackwener jackwener deleted the regression branch August 30, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants