fix(desktop): few WSL bugs#31095
Merged
Merged
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Hona
reviewed
Jun 7, 2026
Member
|
Try not to add new mock modules in tests they are naughty |
neriousy
commented
Jun 7, 2026
| const shell = process.platform === "win32" ? null : getUserShell() | ||
| Object.assign(process.env, { | ||
| ...(shell ? loadShellEnv(shell) : null), | ||
| ...(shell ? loadShellEnv(shell, getLogger()) : null), |
Contributor
Author
There was a problem hiding this comment.
passing logger here cause shell-env test was getting hit with SyntaxError: Export named 'crashReporter' not found in module '/home/neriousy/programming/opencode/node_modules/.bun/electron@41.2.1+759ce506b1ed1a42/node_modules/electron/index.js'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31097
Type of change
What does this PR do?
Fixes
can't access distroReady before initializationFixes removing servers from the sidebar
Fix stale version cache
Added guard so wsl functions don't leak to over envrionments
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
bun dev:desktop
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.