Skip to content

feat(@schematics/angular): route generator#14345

Merged
vikerman merged 1 commit into
angular:masterfrom
hawkgs:lazy-route-generator
Jun 26, 2019
Merged

feat(@schematics/angular): route generator#14345
vikerman merged 1 commit into
angular:masterfrom
hawkgs:lazy-route-generator

Conversation

@hawkgs
Copy link
Copy Markdown
Member

@hawkgs hawkgs commented May 5, 2019

Introduces the lazy routing module generator as part of the existing module generator.

Feature document: Route generator in Angular CLI

Comment thread packages/schematics/angular/utility/project.ts Outdated
Comment thread packages/schematics/angular/utility/project.ts Outdated
Comment thread packages/schematics/angular/utility/project.ts Outdated
Comment thread packages/schematics/angular/utility/project.ts Outdated
Comment thread packages/schematics/angular/module/index.ts Outdated
Comment thread packages/schematics/angular/utility/project.ts Outdated
Comment thread packages/schematics/angular/utility/project.ts Outdated
Comment thread packages/schematics/angular/module/index.ts
Comment thread packages/schematics/angular/module/index.ts Outdated
Comment thread packages/schematics/angular/module/index.ts Outdated
Comment thread packages/schematics/angular/module/index.ts Outdated
Comment thread packages/schematics/angular/module/index.ts Outdated
Comment thread packages/schematics/angular/module/index.ts
Comment thread packages/schematics/angular/module/index.ts Outdated
@hawkgs hawkgs marked this pull request as ready for review May 16, 2019 14:58
@hawkgs hawkgs force-pushed the lazy-route-generator branch 2 times, most recently from 30ba625 to c153562 Compare May 20, 2019 19:58
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label May 24, 2019
Comment thread packages/schematics/angular/utility/ast-utils.ts Outdated
@alan-agius4
Copy link
Copy Markdown
Collaborator

Can you please rebase so we make this green?

@hawkgs hawkgs force-pushed the lazy-route-generator branch from d089825 to 1127346 Compare June 14, 2019 06:34
@hawkgs
Copy link
Copy Markdown
Member Author

hawkgs commented Jun 14, 2019

Done.

Comment thread packages/schematics/angular/module/index_spec.ts
Comment thread packages/schematics/angular/utility/ast-utils.ts
Comment thread packages/schematics/angular/module/index.ts Outdated
Comment thread packages/schematics/angular/module/index.ts Outdated
@alan-agius4 alan-agius4 self-assigned this Jun 18, 2019
@alan-agius4
Copy link
Copy Markdown
Collaborator

Thanks for your contribution and the awesome efforts you put in this PR. Keep up the good work, and I hope that we can have you back with another PR soon :)

@alan-agius4 alan-agius4 force-pushed the lazy-route-generator branch from 77006f9 to 30e5fac Compare June 26, 2019 12:51
@alan-agius4 alan-agius4 added this to the 8.1.x milestone Jun 26, 2019
@vikerman vikerman merged commit fdcd1f7 into angular:master Jun 26, 2019
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants