From dfa0f97718454e934ffb93b59d49343e7c2f0b9b Mon Sep 17 00:00:00 2001
From: Abel John <9206066+abeljohn@users.noreply.github.com>
Date: Thu, 12 Sep 2024 23:12:41 -0700
Subject: [PATCH] fix conditional useHref call

---
 packages/@react-aria/utils/src/openLink.tsx | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/@react-aria/utils/src/openLink.tsx b/packages/@react-aria/utils/src/openLink.tsx
index 489e4f6275b..e0b099508cc 100644
--- a/packages/@react-aria/utils/src/openLink.tsx
+++ b/packages/@react-aria/utils/src/openLink.tsx
@@ -148,8 +148,9 @@ function openSyntheticLink(target: Element, modifiers: Modifiers) {
 
 export function useSyntheticLinkProps(props: LinkDOMProps) {
   let router = useRouter();
+  const href = router.useHref(props.href ?? '');
   return {
-    'data-href': props.href ? router.useHref(props.href) : undefined,
+    'data-href': props.href ? href : undefined,
     'data-target': props.target,
     'data-rel': props.rel,
     'data-download': props.download,
@@ -172,8 +173,9 @@ export function getSyntheticLinkProps(props: LinkDOMProps) {
 
 export function useLinkProps(props: LinkDOMProps) {
   let router = useRouter();
+  const href = router.useHref(props?.href ?? '');
   return {
-    href: props?.href ? router.useHref(props?.href) : undefined,
+    href: props?.href ? href : undefined,
     target: props?.target,
     rel: props?.rel,
     download: props?.download,