fix(decisioning): project malformed-JSON 2xx responses to AdcpError

[bokelley]

Closes #453

The create_upstream_http_client and create_translation_map helpers were already fully implemented and exported from adcp.decisioning. This PR closes the one remaining acceptance-criteria gap: JSON decode errors.

When an upstream returns a successful (2xx) status with a non-JSON body (e.g. a CDN or proxy returns an HTML error page), UpstreamHttpClient._request previously propagated a raw json.JSONDecodeError from response.json(). Adopters catch AdcpError throughout; an unhandled ValueError subclass breaks that contract and is invisible in typed code. This PR wraps the call in except ValueError and re-raises as AdcpError(SERVICE_UNAVAILABLE, recovery="transient") — the same code used for 5xx responses, since an upstream returning HTML for a JSON endpoint is indistinguishable from a transient infrastructure failure.

What changed

• src/adcp/decisioning/upstream.py: wrap response.json() in try/except ValueError; raise AdcpError(SERVICE_UNAVAILABLE) with recovery="transient" and from exc chain.
• tests/test_upstream_helpers.py: add test_200_with_malformed_json_raises_service_unavailable — mocks a 200 with an HTML body and asserts code, recovery, and __cause__.

What tested

• uv run pytest tests/test_upstream_helpers.py tests/test_upstream_for.py -q — 57 passed, 0 failed
• uv run mypy src/adcp/decisioning/upstream.py — clean
• uv run ruff check src/adcp/decisioning/upstream.py tests/test_upstream_helpers.py — clean

Pre-PR review

• code-reviewer: approved — one nit fixed (except Exception → except ValueError; __cause__ assertion added to test)
• dx-expert: approved — SERVICE_UNAVAILABLE with recovery="transient" is correct for a CDN/proxy interception; nit on exception breadth addressed

Nits (not fixed):

• await client.aclose() in the new test is not in a finally block; consistent with the rest of the file's existing test style — test-only resource leak only
• Error message exposes raw exc text rather than a body-length hint; useful for debugging, acceptable

Triage-managed PR. This bot does not currently iterate on
review comments or PR conversation threads (only on the source
issue). To unblock:

• Push fixup commits directly: gh pr checkout <num> →
  fix → push.
• Or re-trigger: comment /triage execute on the source
  issue.

See adcp#3121
for context.

Session: https://claude.ai/code/session_0172h7dGLvfEeo1DLKzAH4TZ

---

Generated by Claude Code

[bokelley]

Triage status: still worth finishing, but this branch has maintainer edits disabled and is behind main, so I cannot update it in place. The source issue #453 is already closed, but the actual change is independently useful: malformed JSON on a 2xx upstream response should project to AdcpError(SERVICE_UNAVAILABLE) instead of leaking JSONDecodeError. Recommended path: author updates this branch against main and changes the PR body from Closes #453 to a non-closing reference, or we re-cut the two-file patch from main in a new branch.

[bokelley]

Re-cut as #836 (claude/issue-453-json-decode-error-recut) from current main (65f84d2). The diff is identical to this branch — except ValueError wrap + AdcpError(SERVICE_UNAVAILABLE, recovery="transient") + the test_200_with_malformed_json_raises_service_unavailable test. PR body uses Refs #453 (issue is already closed). Maintainer edits enabled on the new branch.

Session: https://claude.ai/code/session_018wq8sxhkG9c2WW4vgpYgS8

---

Generated by Claude Code

[bokelley]

Acknowledged — superseded by #836 (claude/issue-453-json-decode-error-recut, rebased on 65f84d2). This draft can be closed once #836 lands.

---

Generated by Claude Code

[bokelley]

Noted — standing by. Will leave this draft open until #836 lands and closes #453; no further bot iteration on this PR.

---

Generated by Claude Code