From cb47d069e0c0ac6b03475b37ade647c34ea97364 Mon Sep 17 00:00:00 2001 From: Frederik Dudzik Date: Mon, 25 May 2020 14:27:19 -0400 Subject: [PATCH 1/4] add deprecation message to rspec command --- ruby/README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ruby/README.md b/ruby/README.md index 5633255f..27babc9b 100644 --- a/ruby/README.md +++ b/ruby/README.md @@ -51,7 +51,9 @@ The runner also comes with a tool to investigate leaky tests: minitest-queue --queue path/to/test_order.log --failing-test 'SomeTest#test_something' bisect -Itest test/**/*_test.rb ``` -### RSpec +### RSpec [DEPRECATED] + +> ⛔️ The rspec-queue runner is DEPRECATED, so we can focus on the minitest-queue runner exclusively and improve it more. Assuming you use one of the supported CI providers, the command can be as simple as: @@ -67,4 +69,4 @@ rspec-queue --queue redis://example.com --timeout 600 --report #### Limitations -Because of how `ci-queue` execute the examples, `before(:all)` and `after(:all)` hooks are not supported. `rspec-queue` will explicitly reject them. \ No newline at end of file +Because of how `ci-queue` execute the examples, `before(:all)` and `after(:all)` hooks are not supported. `rspec-queue` will explicitly reject them. From 443063050be452331475d3be5cc1ebc17fc5abb7 Mon Sep 17 00:00:00 2001 From: Frederik Dudzik <5946811+doodzik@users.noreply.github.com> Date: Mon, 25 May 2020 14:43:01 -0400 Subject: [PATCH 2/4] Update ruby/README.md --- ruby/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/README.md b/ruby/README.md index 27babc9b..52a3612f 100644 --- a/ruby/README.md +++ b/ruby/README.md @@ -53,7 +53,7 @@ minitest-queue --queue path/to/test_order.log --failing-test 'SomeTest#test_some ### RSpec [DEPRECATED] -> ⛔️ The rspec-queue runner is DEPRECATED, so we can focus on the minitest-queue runner exclusively and improve it more. +> The rspec-queue runner is deprecated. The minitest-queue runner continues to be supported and is actively being improved. We recommend that new projects to set up their test suite using Minitest. Assuming you use one of the supported CI providers, the command can be as simple as: From a15c9c6611f357409c28931a4de9e99366973e49 Mon Sep 17 00:00:00 2001 From: Frederik Dudzik <5946811+doodzik@users.noreply.github.com> Date: Mon, 25 May 2020 14:51:26 -0400 Subject: [PATCH 3/4] Update ruby/README.md --- ruby/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/README.md b/ruby/README.md index 52a3612f..7397db7b 100644 --- a/ruby/README.md +++ b/ruby/README.md @@ -53,7 +53,7 @@ minitest-queue --queue path/to/test_order.log --failing-test 'SomeTest#test_some ### RSpec [DEPRECATED] -> The rspec-queue runner is deprecated. The minitest-queue runner continues to be supported and is actively being improved. We recommend that new projects to set up their test suite using Minitest. +The rspec-queue runner is deprecated. The minitest-queue runner continues to be supported and is actively being improved. At Shopify, we strongly recommend that new projects set up their test suite using Minitest rather than RSpec. Assuming you use one of the supported CI providers, the command can be as simple as: From f8da675178243f3c34dc7f499ae31629b8e2daa3 Mon Sep 17 00:00:00 2001 From: Frederik Dudzik <5946811+doodzik@users.noreply.github.com> Date: Mon, 25 May 2020 14:56:06 -0400 Subject: [PATCH 4/4] Update ruby/README.md Co-authored-by: Jessica Xie --- ruby/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/README.md b/ruby/README.md index 7397db7b..5930a0e1 100644 --- a/ruby/README.md +++ b/ruby/README.md @@ -69,4 +69,4 @@ rspec-queue --queue redis://example.com --timeout 600 --report #### Limitations -Because of how `ci-queue` execute the examples, `before(:all)` and `after(:all)` hooks are not supported. `rspec-queue` will explicitly reject them. +Because of how `ci-queue` executes the examples, `before(:all)` and `after(:all)` hooks are not supported. `rspec-queue` will explicitly reject them.