fix(page-router-outlet): actionBarVisibility not applied#1621
Merged
fix(page-router-outlet): actionBarVisibility not applied#1621
Conversation
…lazy loaded named outlet
ghost
added
the
manoldonev
previously approved these changes
Nov 20, 2018
MartoYankov
previously approved these changes
Nov 21, 2018
ADjenkov
dismissed stale reviews from MartoYankov and manoldonev
via
571b39f
SvetoslavTsenov
approved these changes
Nov 23, 2018
SvetoslavTsenov
pushed a commit
that referenced
this pull request
Nov 26, 2018
* fix(p-r-o): actionBarVisibility has no effect when applied to nested lazy loaded named outlet * tets: add tests for actionBarVisibility and lazy loaded named outlet * chore: include images for ios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actionBarVisibilityproperty has no effect when applied to nested lazy loaded named outlet.NSEmptyOutlet
<page-router-outlet>should inherit its parent frameactionBarVisibilitye2e tests added for
actionBarVisibilitywith lazy loaded named outlet