fix: crash in deactivate page router outlet#1590
Merged
manoldonev merged 2 commits intomasterfrom Nov 6, 2018
Merged
Conversation
ghost
assigned
ADjenkov
previously approved these changes
Nov 6, 2018
manoldonev
approved these changes
Nov 6, 2018
Contributor
manoldonev
left a comment
manoldonev
left a comment
There was a problem hiding this comment.
We can patch this like this at the moment but someone (maybe @ADjenkov) should investigate the root cause of this i.e. why deactivate(...) is called and there is no outlet.
Contributor
Author
|
We have already discussed it with @ADjenkov and he will further make some investigations but for now this fix seems to be quite safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.