Android Runtime Updates and One Shared Engine Layer - #67
Draft
ammarahm-ed wants to merge 332 commits into
Draft
Conversation
(cherry picked from commit 8a23b3d)
(cherry picked from commit ce33b79)
…ckjs-ng 0.11.0 (cherry picked from commit 0cdbec7)
(cherry picked from commit 39a1e6e)
(cherry picked from commit f99795f)
(cherry picked from commit f5c5855)
(cherry picked from commit 6dd09a3)
(cherry picked from commit 11a71e0)
…ple and Android (cherry picked from commit a94ced2)
(cherry picked from commit 0d2b946)
…K r29 (cherry picked from commit 53135f4)
(cherry picked from commit 3f5c673)
(cherry picked from commit 2f20a95)
(cherry picked from commit 957f1f3)
(cherry picked from commit b7b745d)
(cherry picked from commit d4e2f34)
(cherry picked from commit 130c728)
…ess specs (cherry picked from commit eff805d)
(cherry picked from commit 0fec65b)
(cherry picked from commit 1c68fc5)
…le build (cherry picked from commit 6cc2d23)
(cherry picked from commit daad6082818715b18bca7f01f24681cb5db8473c)
(cherry picked from commit 516f3220a7a0d26fb6c0520c28d5a84fb44fd289)
…away (cherry picked from commit 869f7dbf1fd823dc425183e71f79f22cf5bd2d7d)
(cherry picked from commit c92f338dab01e793049f22a3ee5b0c46ba54e830)
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the android layer to latest changes from https://github.com/NativeScript/napi-android and in doing so collapses the two per-platform engine layers into a single unified layer.
Apple and Android now share a single backend per engine rather than keeping parallel copies that drift, run against the same engine versions, and fetch their prebuilt binaries on demand instead of carrying them in the repository.
NativeScript/napi/<engine>/now includes only the jsr layer.vendor/has all engine related headers, sources, napi bindings etc shared by both Apple & AndroidWhat changed
One engine layer for both platforms
mimallocis also removed as it stopped making a performance difference in latest quickjs engines.Android runtime
andorid/.githubshould be removed.URL
Runtime correctness
Verified
Notes for reviewers