Skip to content

Commit 751fc4f

Browse files
committed
ci: drop the go-sdk compatibility surface
With sdk/go removed, the compatibility review has no Go SDK left to review. Remove go-sdk from the required surfaces in the review prompt and in the report validator, which rejects reviews that don't cover exactly the listed surfaces, and drop Go from the CI.md descriptions of the compatibility review, CodeQL, and the release publishers. Signed-off-by: Roland Huß <rhuss@redhat.com>
1 parent 8cd6c7b commit 751fc4f

3 files changed

Lines changed: 8 additions & 18 deletions

File tree

‎.github/prompts/compatibility-review.md‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,9 @@ needed.
113113

114114
## Required surfaces
115115

116-
Account for every surface: `rust-sdk`, `python-sdk`, `go-sdk`, `typescript-sdk`,
117-
`api-behavior`, `cli`, `configuration`, `policy`, `helm`, and `state`.
116+
Account for every surface: `rust-sdk`, `python-sdk`, `typescript-sdk`,
117+
`api-behavior`, `cli`, `configuration`, `policy`, `helm`, and `state`. The Go
118+
SDK moved to ai-openshell/sdk-go and is not a surface of this repository.
118119

119120
Scope `rust-sdk` to the public API reachable through `openshell-sdk`, including
120121
its `raw` module and transitive public re-exports. Trace the export path before
@@ -126,16 +127,6 @@ generated server-trait changes reachable through `raw::proto`, identifying
126127
mock/server implementers as affected consumers and distinguishing them from
127128
unaffected client callers.
128129

129-
For `go-sdk`, adopt the [Go struct-literal compatibility convention](https://go.dev/doc/go1compat):
130-
adding fields to exported structs is additive when existing keyed literals remain
131-
valid and omitted fields preserve existing behavior. Do not report a break solely
132-
because unkeyed (positional) literals need updating, unless the baseline explicitly
133-
guarantees that construction form. Still inspect existing field names and types,
134-
zero-value behavior, comparability (equality and map keys), and serialization
135-
contracts; a field addition can break those independently. Follow the
136-
[Go module compatibility guidance](https://go.dev/blog/module-compatibility#maintaining-struct-compatibility)
137-
for these limits. This exception applies only to Go struct-field additions.
138-
139130
Check exported signatures/types, generated and handwritten SDK behavior,
140131
serialization and error contracts, command flags and documented machine-readable
141132
output, config/default semantics, policy formats, chart values, and persisted

‎CI.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ qualification. Branch checks compare the prospective merge tree with its target,
9494
using workflow-revision review tooling and the target's tag-derived train policy.
9595
Release qualification reviews the cumulative diff from the previous reachable
9696
stable release to the exact candidate commit, using the same tag-derived
97-
patch/minor policy as the protobuf check. It reviews public Rust, Python, Go,
98-
and TypeScript SDKs, API behavior, CLI contracts, configuration, policy, Helm,
97+
patch/minor policy as the protobuf check. It reviews public Rust, Python, and
98+
TypeScript SDKs, API behavior, CLI contracts, configuration, policy, Helm,
9999
and persisted state.
100100
Both Codex workflows share the `codex-release-review` concurrency group with
101101
`queue: max`, so only one review runs at a time and up to 100 pending reviews
@@ -245,7 +245,7 @@ scanners upload results directly:
245245
warn-only mode. A preflight turns an unavailable GitHub Dependency Graph into
246246
a warning, so the workflow remains neutral until the repository feature is
247247
available.
248-
- `CodeQL` analyzes product Rust code, examples, and the Go, Python, and
248+
- `CodeQL` analyzes product Rust code, examples, and the Python and
249249
TypeScript SDKs. Rust `cfg(test)` blocks, Rust integration-test targets, and
250250
E2E test code are excluded. It runs nightly on `main`, remains manually
251251
dispatchable for diagnostics, uploads results to Code Scanning, and retains
@@ -707,7 +707,7 @@ The bot's full administrator documentation is internal to NVIDIA. The only comma
707707
| `.github/workflows/e2e-label-help.yml` | When a `test:e2e*` label is applied, posts a PR comment telling the maintainer the next manual step (re-run an existing workflow run, or `/ok to test <SHA>` to refresh the mirror). |
708708
| `.github/workflows/workflow-security.yml` | Runs informational Actionlint and High-severity Zizmor reports on GitHub-hosted runners. |
709709
| `.github/workflows/dependency-review.yml` | Reports dependency changes when GitHub Dependency Graph is available; otherwise publishes a neutral warning. |
710-
| `.github/workflows/codeql.yml` | Runs nightly informational CodeQL analysis on `main` for Rust and the Go, Python, and TypeScript SDKs and retains SARIF artifacts. |
710+
| `.github/workflows/codeql.yml` | Runs nightly informational CodeQL analysis on `main` for Rust and the Python and TypeScript SDKs and retains SARIF artifacts. |
711711
| `.github/workflows/codex-security.yml` | Advisory scan during prerelease qualification; scans the stable-to-candidate diff and publishes train-scoped SARIF on `main`. |
712712
| `.github/workflows/codex-compatibility.yml` | Reviews branch and cumulative tagged-release compatibility with Codex and retains advisory findings, PR acknowledgements, and coverage; it does not gate merging or publication. |
713713
| `.github/workflows/trivy-changes.yml` | Blocks pull requests and merge groups that introduce new High or Critical Helm or Dockerfile misconfigurations. |
@@ -726,7 +726,7 @@ Each step that publishes to an external registry, store, or site lives in its ow
726726
| `.github/workflows/release-auto-tag.yml` | Weekdays at 14:00 Europe/Zurich, tags the next `-pre.N` on `main` when commits landed since the latest one, then dispatches Pre-release. It skips when the train has no `-pre.1` or its version is already stable, so push each train's `-pre.1` tag by hand. |
727727
| `.github/workflows/release-prerelease.yml` | Pre-release orchestrator, triggered by prerelease tag pushes or dispatched by Release Auto-Tag or manually. A tagless dispatch creates the next candidate on its branch; explicit tags select existing candidates. Builds, then publishes and qualifies in parallel. Qualification failure fails the run and sends the failure notification; published artifacts remain available. |
728728
| `.github/workflows/release-build.yml` | Shared version computation, binary and image builds, and package builds. Validates that the tag matches the caller's release kind. |
729-
| `.github/workflows/release-publish.yml` | Shared artifact assembly, OCI image tags and Helm chart publication, and package publication. Stable releases also publish release-labeled public schemas to Buf (`BUF_TOKEN` required) and GitHub Releases, and call the snap, npm, and Go SDK publishers. The Python SDK is released from [ai-openshell/sdk-python](https://github.com/ai-openshell/sdk-python), so no GitHub Release carries a wheel. |
729+
| `.github/workflows/release-publish.yml` | Shared artifact assembly, OCI image tags and Helm chart publication, and package publication. Stable releases also publish release-labeled public schemas to Buf (`BUF_TOKEN` required) and GitHub Releases, and call the snap and npm publishers. The Python SDK is released from [ai-openshell/sdk-python](https://github.com/ai-openshell/sdk-python), so no GitHub Release carries a wheel. |
730730
| `.github/workflows/release-notes.yml` | Shared prompt-driven release notes generation through Inference Hub, used by prerelease previews, notes-only previews, and stable releases. Stable releases reuse the promoted prerelease's preview when available. |
731731
| `.github/workflows/release-qualification.yml` | Reusable qualification suites and result aggregation. Runs security scans, conformance and feature integration, Docker and VM E2E, protobuf compatibility, and advisory compatibility review. |
732732
| `.github/workflows/snap-package.yml` | Builds snap and component artifacts for Release Dev, Release, and Pre-release without Store credentials or publication. |

‎tasks/scripts/codex_compatibility_report.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
SURFACES = (
1212
"rust-sdk",
1313
"python-sdk",
14-
"go-sdk",
1514
"typescript-sdk",
1615
"api-behavior",
1716
"cli",

0 commit comments

Comments
 (0)