From 550a3e30e17179e71a5feb8215dfcf0c9ccf7b62 Mon Sep 17 00:00:00 2001 From: netanelC Date: Tue, 28 Mar 2023 15:02:58 +0300 Subject: [PATCH 1/2] fix: throws error instead of returning undefined --- src/jobManagerClient.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jobManagerClient.ts b/src/jobManagerClient.ts index ce290c0..667b877 100644 --- a/src/jobManagerClient.ts +++ b/src/jobManagerClient.ts @@ -96,7 +96,7 @@ export class JobManagerClient extends HttpClient { msg: `failed to getJob for jobId=${jobId}`, errorMessage: (err as { message: string }).message, }); - return undefined; + throw err; } } From 2a5e6796486568393d57eaeb7ec06ee7936dd522 Mon Sep 17 00:00:00 2001 From: netanelC Date: Tue, 28 Mar 2023 16:30:33 +0300 Subject: [PATCH 2/2] chore: removed undefined --- src/jobManagerClient.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jobManagerClient.ts b/src/jobManagerClient.ts index 667b877..86f32ce 100644 --- a/src/jobManagerClient.ts +++ b/src/jobManagerClient.ts @@ -76,7 +76,7 @@ export class JobManagerClient extends HttpClient { } } - public async getJob(jobId: string, shouldReturnTasks = false): Promise | undefined> { + public async getJob(jobId: string, shouldReturnTasks = false): Promise> { const getJobUrl = this.getJobUrl(jobId); try { this.logger.debug({