feat: add job and task creation#6
Merged
Merged
Conversation
asafMasa
commented
Aug 23, 2021
asafMasa
commented
Contributor
| Question | Answer |
|---|---|
| New feature | ✔ |
cl-shaharshavit-rnd
suggested changes
Aug 23, 2021
| } | ||
|
|
||
| public async updateTask(jobId: string, taskId: string, payload: IUpdateTaskRequestPayload): Promise<void> { | ||
| public async createTask(jobId: string, payload: IUpdateTaskBody): Promise<void> { |
Contributor
There was a problem hiding this comment.
rename to enqueue
| const createJobUrl = `/jobs`; | ||
| await this.post(createJobUrl, payload); | ||
| } catch (err) { | ||
| this.logger.error(`failed to create job`); |
Contributor
There was a problem hiding this comment.
add data to log.
what job?
| const logFormat = `jobId=${jobId}, taskId=${taskId}`; | ||
| try { | ||
| this.logger.info(`get task ${logFormat}`); | ||
| this.logger.info(`${logFormat} get task`); |
Contributor
There was a problem hiding this comment.
make logs more readable
| return task; | ||
| } catch (err) { | ||
| this.logger.error(`failed to get task ${logFormat}`); | ||
| this.logger.error(`${logFormat} failed to get task`); |
Contributor
There was a problem hiding this comment.
make logs more readable
| const tasks = await this.get<ITaskResponse[]>(getTaskUrl); | ||
| return tasks; | ||
| } catch (err) { | ||
| this.logger.error(`${logFormat} failed to get tasks`); |
Contributor
There was a problem hiding this comment.
make logs more readable
| return task; | ||
| } catch (err) { | ||
| this.logger.error(`failed to get task ${logFormat}`); | ||
| this.logger.error(`[JobManagerClient][getTask] jobId=${jobId}, taskId=${taskId} failed to get task`); |
Contributor
There was a problem hiding this comment.
add error message
cl-shaharshavit-rnd
suggested changes
Aug 23, 2021
| const tasks = await this.get<ITaskResponse[]>(getTaskUrl); | ||
| return tasks; | ||
| } catch (err) { | ||
| this.logger.error(`[JobManagerClient][getTasksForJob] jobId=${jobId} failed`); |
Contributor
There was a problem hiding this comment.
add error message
| return job; | ||
| } catch { | ||
| this.logger.error(`failed to get job data for job: ${jobId}`); | ||
| this.logger.error(`[JobManagerClient][getJob] jobId=${jobId} failed`); |
Contributor
There was a problem hiding this comment.
add error message
| return null; | ||
| } else { | ||
| this.logger.error(`failed to consume ${logFormat}`); | ||
| this.logger.error(`[JobManagerClient][consume] jobType=${this.jobType}, taskType=${this.taskType}, failed to consume`); |
Contributor
There was a problem hiding this comment.
add error message
| const createTaskUrl = `/jobs/${jobId}/tasks`; | ||
| await this.post(createTaskUrl, payload); | ||
| } catch (err) { | ||
| this.logger.error(`[JobManagerClient][enqueueTask] jobId=${jobId}, payload=${JSON.stringify(payload)} failed`); |
Contributor
There was a problem hiding this comment.
add error message
| const createJobUrl = `/jobs`; | ||
| await this.post(createJobUrl, payload); | ||
| } catch (err) { | ||
| this.logger.error(`[JobManagerClient][createJob] payload=${JSON.stringify(payload)} failed`); |
Contributor
There was a problem hiding this comment.
add error message
| await this.put(updateTaskUrl, payload); | ||
| } catch (err) { | ||
| this.logger.error(`failed to update task ${logFormat}`); | ||
| this.logger.error(`[JobManagerClient][updateTask] jobId=${jobId}, taskId=${taskId}, payload=${JSON.stringify(payload)} failed`); |
Contributor
There was a problem hiding this comment.
add error message
| await this.put(updateJobUrl, payload); | ||
| } catch (err) { | ||
| this.logger.error(`failed to update job Id=${jobId}`); | ||
| this.logger.error(`[JobManagerClient][updateJob] jobId=${jobId}, payload=${JSON.stringify(payload)} failed`); |
Contributor
There was a problem hiding this comment.
add error message
cl-shaharshavit-rnd
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.