From 802425f7fda838f354523d745e353d54a56b28ac Mon Sep 17 00:00:00 2001 From: RealDiligent Date: Mon, 27 Jul 2026 01:25:05 +0800 Subject: [PATCH] test(review): seed the live pull_requests ledger for the submission-cadence tests #9041 moved getSubmitterCadence off review_targets (frozen at the self-host cutover) to read the live pull_requests table, but the cadence test's local seed helper still wrote only review_targets. The query therefore read zero samples, so the machine-paced submitter assertion failed on main and broke validate-tests for every branch. Seed pull_requests alongside review_targets in the cadence helper so the signal has the live data it now reads, without disturbing the merged/approved review_targets rows that keep the quality signal neutral. --- test/unit/reputation-wiring.test.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/unit/reputation-wiring.test.ts b/test/unit/reputation-wiring.test.ts index ba0c166194..b127d37d65 100644 --- a/test/unit/reputation-wiring.test.ts +++ b/test/unit/reputation-wiring.test.ts @@ -279,12 +279,21 @@ describe("shouldSkipAiForReputation (helper)", () => { describe("submission-cadence signal (#4514)", () => { async function seedReviewTarget(env: Env, args: { number: number; submitter: string; createdAt: string }) { + // Merged/approved review_targets keep the QUALITY signal neutral/trusted, so only cadence can trip these. await env.DB.prepare( `INSERT INTO review_targets (id, project, kind, repo, number, submitter, status, decision_json, terminal_at, created_at) VALUES (?, 'acme/widgets', 'pull_request', 'acme/widgets', ?, ?, 'merged', ?, ?, ?)`, ) .bind(`acme/widgets:pull_request:acme/widgets#${args.number}`, args.number, args.submitter, JSON.stringify({ reasonCode: "dual_review_approved" }), args.createdAt, args.createdAt) .run(); + // #9041 moved getSubmitterCadence off the cutover-frozen review_targets to the LIVE pull_requests ledger, + // so the submission-cadence signal is sourced from here now -- seed it too or the query reads 0 samples. + await env.DB.prepare( + `INSERT INTO pull_requests (id, repo_full_name, number, title, state, author_login, created_at) + VALUES (?, 'acme/widgets', ?, 'PR', 'open', ?, ?)`, + ) + .bind(`acme/widgets#${args.number}`, args.number, args.submitter, args.createdAt) + .run(); } it("FLAG-ON: true for a machine-paced submitter even though every submission itself looks fine (quality-neutral)", async () => {