From abaf95f7702b75484af5ff47753d80ee1dcb115e Mon Sep 17 00:00:00 2001
From: JSONbored <49853598+JSONbored@users.noreply.github.com>
Date: Sat, 11 Jul 2026 02:49:20 -0700
Subject: [PATCH] test(miner-governor): close branch-coverage gaps in
 self-review adapter tests

Measured coverage (node --experimental-test-coverage) showed
self-review-adapter.js at only 50% branch coverage despite the existing
suite looking thorough -- four optional-field ternary spreads and one
?.length ?? 0 fallback each had only one side exercised. Add targeted
tests for the untaken branches; file now measures 100/100/100
(lines/branch/funcs).
---
 .../test/self-review-adapter.test.ts          | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/packages/gittensory-engine/test/self-review-adapter.test.ts b/packages/gittensory-engine/test/self-review-adapter.test.ts
index 7de188807d..37c66a4801 100644
--- a/packages/gittensory-engine/test/self-review-adapter.test.ts
+++ b/packages/gittensory-engine/test/self-review-adapter.test.ts
@@ -68,6 +68,27 @@ test("buildSelfReviewPredictedGateInput: maps identity fields, omitting keys the
   assert.ok(!("labels" in input), "labels must be omitted, not set to undefined, when the diff state has none");
 });
 
+test("buildSelfReviewPredictedGateInput: includes labels and authorAssociation when the diff state sets them", () => {
+  const input = buildSelfReviewPredictedGateInput({
+    ...BASE_DIFF_STATE,
+    labels: ["gittensor:feature"],
+    authorAssociation: "CONTRIBUTOR",
+  });
+  assert.deepEqual(input.labels, ["gittensor:feature"]);
+  assert.equal(input.authorAssociation, "CONTRIBUTOR");
+});
+
+test("buildSelfReviewPredictedGateInput: omits body and linkedIssues when the diff state leaves them undefined", () => {
+  const input = buildSelfReviewPredictedGateInput({
+    repoFullName: "acme/widgets",
+    contributorLogin: "miner1",
+    title: "Add retry to the upload client",
+    changedFiles: [],
+  });
+  assert.ok(!("body" in input));
+  assert.ok(!("linkedIssues" in input));
+});
+
 test("buildSelfReviewChangedPaths: extracts the real changed file paths", () => {
   const paths = buildSelfReviewChangedPaths({
     ...BASE_DIFF_STATE,
@@ -85,6 +106,11 @@ test("buildSelfReviewSlopInput: derives hasLinkedIssue from the diff state and t
   const withoutIssue = buildSelfReviewSlopInput({ ...BASE_DIFF_STATE, linkedIssues: [], body: undefined }, baseContext());
   assert.equal(withoutIssue.hasLinkedIssue, false);
   assert.equal(withoutIssue.description, null, "an undefined body normalizes to null, matching SlopAssessmentInput's own nullable field");
+
+  // linkedIssues entirely UNDEFINED (not just an empty array) exercises the `?.length ?? 0` fallback chain
+  // distinctly from the empty-array case above.
+  const undefinedIssues = buildSelfReviewSlopInput({ ...BASE_DIFF_STATE, linkedIssues: undefined }, baseContext());
+  assert.equal(undefinedIssues.hasLinkedIssue, false);
 });
 
 test("runSelfReview: a genuinely passing synthetic diff matches calling buildPredictedGateVerdict directly", () => {
@@ -151,6 +177,26 @@ test("runSelfReview: threads changedPaths through so path-dependent checks are e
   assert.equal(result.changedPaths[0], "src/upload.ts");
 });
 
+test("runSelfReview: forwards optional context fields (bounties, issueQuality, confirmedContributor) through to buildPredictedGateVerdict", () => {
+  const context = baseContext({ confirmedContributor: true, bounties: [], issueQuality: null });
+  const result = runSelfReview(BASE_DIFF_STATE, context, { runSlopAssessment: () => noopSlop });
+
+  assert.equal(result.predictedGateVerdict.confirmedContributor, true);
+
+  const direct = buildPredictedGateVerdict({
+    input: buildSelfReviewPredictedGateInput(BASE_DIFF_STATE),
+    manifest: context.manifest,
+    repo: context.repo,
+    issues: context.issues,
+    pullRequests: context.pullRequests,
+    bounties: [],
+    issueQuality: null,
+    confirmedContributor: true,
+    changedPaths: ["src/upload.ts"],
+  });
+  assert.deepEqual(result.predictedGateVerdict, direct);
+});
+
 test("runSelfReview: passes the exact constructed slop input to the injected dependency and returns its result unchanged", () => {
   let received: unknown;
   const distinctiveSlop: SelfReviewSlopAssessment = { slopRisk: 42, band: "elevated", findings: [{ code: "x", title: "t", severity: "warning", detail: "d" }] };