Skip to content

Added visuality and json reader challenge - #11

Merged
johanbeytell1 merged 9 commits into
Infinitode:mainfrom
Ericwasepic127:main
Aug 5, 2026
Merged

Added visuality and json reader challenge#11
johanbeytell1 merged 9 commits into
Infinitode:mainfrom
Ericwasepic127:main

Conversation

@Ericwasepic127

Copy link
Copy Markdown
Contributor

Fix needed i was hurrying up

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs / Issues:

  1. Invalid typo and return without value returns None; then if not dic: will fail if your JSON is empty {}, [], 0, false
  2. dic.items() will crash if the JSON root is a list, not a dict
  3. os.listdir() with no path + printing everything in cwd on start is noisy and can leak sensitive dir info
  4. No separation of concerns - logic, printing, and input all mixed together
  5. No if name == "main": guard

Refactor JSON reader to improve error handling and code structure.
Comment thread main.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re not including main.py due to the nature of the project. It’s designed to be a quick, grab-and-go setup where users can clone it, run it on their own systems, and learn from the README and solutions if needed. A file viewer isn’t necessary right now, since most file viewers and IDEs already handle that well.

Updated project counts and fixed typos in the README.
Comment thread README.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not be adding live demos for any of the Python projects in this repository. This decision is made to ensure the security and trust of our users. By doing so, we allow them to run the clean code on their own systems without any compromise on our part.

@johanbeytell1
johanbeytell1 merged commit 3a589cc into Infinitode:main Aug 5, 2026
@johanbeytell1

Copy link
Copy Markdown
Member

Thanks for your contributions, @Ericwasepic127. As always, have a good one.

@Ericwasepic127

Copy link
Copy Markdown
Contributor Author

thanks - also I was hurrying up in there sorry 😆😊😁👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants