diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e87e751..b3bd829 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -13,10 +13,13 @@ variables: # set up the basic job .runtests: before_script: - - "conda create --prefix /root/factordev --channel conda-forge --file requirements.txt python=${PYVERSION} codecov nose nose-cov --yes --quiet" + - "conda create --prefix /root/factordev --channel conda-forge --file requirements.txt python=${PYVERSION} curl nose nose-cov --yes --quiet" - /root/factordev/bin/pip install -e . + - /root/factordev/bin/curl -o /root/factordev/bin/codecov https://uploader.codecov.io/latest/linux/codecov + - chmod +x /root/factordev/bin/codecov script: - "/root/factordev/bin/nosetests ${TESTFILES}" + - "/root/factordev/bin/coverage xml" after_script: - /root/factordev/bin/codecov diff --git a/factor_analyzer/confirmatory_factor_analyzer.py b/factor_analyzer/confirmatory_factor_analyzer.py index 2e9655f..7b2a4c3 100644 --- a/factor_analyzer/confirmatory_factor_analyzer.py +++ b/factor_analyzer/confirmatory_factor_analyzer.py @@ -741,7 +741,7 @@ def fit(self, X, y=None): # so that we can avoid using linear programming methods (e.g. SLSQP) res = minimize( self._objective, - x0, + x0.flatten(), method="L-BFGS-B", options={"maxiter": self.max_iter, "disp": self.disp}, bounds=self.bounds,