fix(otel): cents-scale bucket boundaries for session.cost.total histogram#59
Open
TestardR wants to merge 1 commit into
Open
fix(otel): cents-scale bucket boundaries for session.cost.total histogram#59TestardR wants to merge 1 commit into
TestardR wants to merge 1 commit into
Conversation
…istogram The session.cost.total histogram was using OTel SDK default bucket boundaries [0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000, +Inf] which are USD-scale. Since typical opencode session costs are sub-dollar, 100% of samples land in the le=5 bucket and P50/P95 panels in SigNoz return empty. Add advice.explicitBucketBoundaries with cents-scale boundaries: [0.01, 0.05, 0.10, 0.25, 0.50, 1.00, 2.50, 5.00, 10.00, 25.00] These cover the realistic distribution of per-session costs and produce meaningful percentile values in downstream observability tooling.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the observability telemetry configuration by adding explicit bucket boundaries to the ChangesSession cost histogram configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
opencode.session.cost.totalis a Histogram registered without explicit bucket boundaries, so the OTel JS SDK applies defaults[0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000](USD-scale).Real-world session costs are typically under $1, so every observation lands in the
le=5bucket. P50/P95 panels return 0 because the histogram can't resolve sub-$5 percentiles.Fix
Add
advice.explicitBucketBoundarieswith cents-scale boundaries:[0.01, 0.05, 0.10, 0.25, 0.50, 1.00, 2.50, 5.00, 10.00, 25.00].Evidence
ClickHouse bucket distribution against a live SigNoz (all 267 samples in
le=5):Bucket change affects new data only; existing histograms keep their old boundaries.
Companion PR: #58
Summary by CodeRabbit