Skip to content

feat(statics): replace Story explorer URLs with Data Network - #9691

Draft
manojkumar138 wants to merge 1 commit into
masterfrom
manojkumar138/cecho-2075-replace-rpc-urls-from-storyip-to-data-network
Draft

feat(statics): replace Story explorer URLs with Data Network#9691
manojkumar138 wants to merge 1 commit into
masterfrom
manojkumar138/cecho-2075-replace-rpc-urls-from-storyip-to-data-network

Conversation

@manojkumar138

Copy link
Copy Markdown
Contributor

Summary

  • Replace IP mainnet/testnet explorer and account explorer hosts from storyscan.iodatanetscan.io in statics networks
  • Update sdk-core environment explorer baseUrls to match
  • Part of CECHO-2075 Phase 1 (display/link hosts only; no public RPC change in this PR)

Test plan

  • Confirm statics explorerUrl / accountExplorerUrl for ip / tip networks point at datanetscan
  • Confirm sdk-core env baseUrls updated for ip/tip
  • Spot-check a sample explorer tx/address URL resolves on datanetscan.io / aeneid.datanetscan.io

Ticket: CECHO-2075

Made with Cursor

Update IP mainnet/testnet explorer and account explorer hosts from
storyscan.io to datanetscan.io, and sdk-core environment baseUrls.

Ticket: CECHO-2075
Co-authored-by: Cursor <cursoragent@cursor.com>
@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

CECHO-2075

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude review

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task —— View job


Code Review Progress ✅

  • Read changed files to understand current state
  • View git diff to see exact changes
  • Analyze changes for correctness and consistency
  • Check for potential issues or improvements
  • Provide comprehensive review feedback

Review Summary

This PR successfully replaces Story explorer URLs with Data Network URLs as described. The changes are clean, consistent, and follow the expected pattern.

Changes Analyzed

1. modules/sdk-core/src/bitgo/environments.ts (lines 278, 525):

  • Mainnet: baseUrl: 'https://www.storyscan.io''https://datanetscan.io'
  • Testnet: baseUrl: 'https://aeneid.storyscan.io''https://aeneid.datanetscan.io'

2. modules/statics/src/networks.ts (lines 1689-1690, 1698-1699):

  • IP Mainnet:
    • explorerUrl: 'https://www.storyscan.io/tx/''https://datanetscan.io/tx/'
    • accountExplorerUrl: 'https://www.storyscan.io/address/''https://datanetscan.io/address/'
  • IPTestnet:
    • explorerUrl: 'https://aeneid.storyscan.io/tx/''https://aeneid.datanetscan.io/tx/'
    • accountExplorerUrl: 'https://aeneid.storyscan.io/address/''https://aeneid.datanetscan.io/address/'

Review Feedback

✅ Strengths:

  1. Consistent URL structure: All changes maintain the same URL path structure (/tx/, /address/)
  2. Complete coverage: Both mainnet and testnet environments are updated in both files
  3. Proper scoping: Changes are focused only on the IP (Data Network) coin family
  4. URL format consistency: Testnet properly uses subdomain format (aeneid.datanetscan.io)

✅ No Issues Found:

  • No hardcoded storyscan URLs remain in the changed files
  • URL formats are valid and follow expected patterns
  • Chain IDs and other properties remain unchanged (as expected for Phase 1)
  • No breaking changes to the API structure

💡 Suggestions for Test Plan:
The test plan items look appropriate:

  • ✅ Verify statics explorerUrl/accountExplorerUrl point to datanetscan
  • ✅ Verify sdk-core env baseUrls updated
  • ✅ Spot-check sample URLs resolve on datanetscan.io

Overall Assessment: ✅ APPROVED

This is a clean, straightforward URL update that correctly implements Phase 1 of CECHO-2075. The changes are minimal, focused, and maintain consistency across both mainnet and testnet environments.


Branch: manojkumar138/cecho-2075-replace-rpc-urls-from-storyip-to-data-network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant