perf(sdk-core): pin high-entropy encryption to v1 - #9685
Merged
Conversation
Contributor
Contributor
|
|
danielpeng1
requested changes
Sep 9, 2026
danielpeng1
left a comment
Contributor
There was a problem hiding this comment.
commit needs to be signed
pranavjain97
force-pushed
the
pranavjain/high-entropy-kdf-no-argon2
branch
from
September 9, 2026 17:55
a600af5 to
901400b
Compare
pranavjain97
force-pushed
the
pranavjain/high-entropy-kdf-no-argon2
branch
from
September 9, 2026 19:29
901400b to
f58f08a
Compare
danielpeng1
previously approved these changes
Sep 9, 2026
pranavjain97
force-pushed
the
pranavjain/high-entropy-kdf-no-argon2
branch
from
September 9, 2026 21:19
f58f08a to
ab92e68
Compare
danielpeng1
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TICKET: WCN-2616
Test plan
modules/sdk-core:yarn unit-test --grep "encryptionVersion threading"(9 passing)modules/key-card:yarn unit-test(37 passing)modules/sdk-core:yarn lintmodules/key-card:eslint --quiet src testyarn check-commitsyarn lint-changedcannot enumerate packages from a worktree nested under the repository; Lerna resolves../../modules/*outside this worktree.