Clarify and improve scan_layers mismatch error handling#4099
Open
shralex wants to merge 1 commit into
Open
Conversation
shralex
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jacoguzo,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
shralex
force-pushed
the
shralex_ux3
branch
4 times, most recently
from
339e43f to
5ace97a
Compare
shralex
changed the title
shralex
force-pushed
the
shralex_ux3
branch
2 times, most recently
from
c832537 to
21c7a8f
Compare
shralex
force-pushed
the
shralex_ux3
branch
3 times, most recently
from
f833914 to
1615d76
Compare
| ) | ||
|
|
||
| except Exception as e: | ||
| if is_structural_or_shape_mismatch(e): |
Collaborator
There was a problem hiding this comment.
We do have something similar in main: https://github.com/AI-Hypercomputer/maxtext/blob/main/src/maxtext/utils/model_creation_utils.py#L439.
Collaborator
Author
There was a problem hiding this comment.
I unified the code so that on the top level the same message is thrown.
shralex
force-pushed
the
shralex_ux3
branch
2 times, most recently
from
54be25e to
d5fa10b
Compare
…in conversion, training and checkpoints
khatwanimohit
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scan_layers is inconsistent between checkpoint creation and training, Orbax throws an error.
This PR documents this and improves error handling across all possible restore paths.
FIXES: b/520780284
Tests
Unit and integration tests were added to verify error handling.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.